Rearrange async code to fix httpx pool timeouts #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we tried to run validation tasks for ALL the patients in parallel, using a task group for each patient. That led to HTTPX pool timeouts with real data - the default is 5 seconds. This rearranges the async handling to do bounded parallelism at the patient level - ie only handle max 5 patients in flight at once. The old task group was actually redundant as we now parallelise lookups in external_patient_validators and external_visit_validators using asyncio.gather
Didn't handle patients that couldn't be saved Was always using the last patient (needed to be a parameter to the task)
That should then apply in the questionnaire too and if we manually muck about in the Django shell
mbarton
force-pushed
the
mbarton/actually-do-parallelism-properly
branch
from
e4abd44 to
bb57803
Compare
mbarton
commented
Feb 9, 2025
| @@ -366,11 +423,6 @@ def test_invalid_nhs_number(test_user, single_row_valid_df): | |||
| errors = csv_upload_sync(test_user, single_row_valid_df) | |||
| assert "nhs_number" in errors[0] | |||
|
|
|||
| # Catastrophic - Patient not save | |||
There was a problem hiding this comment.
It's fine to save an invalid NHS number, it will be flagged in the data quality report and UI
It breaks a bunch of unrelated tests to move it to Patient.save
mbarton
added
Pending-on-STAGING
Pending-on-LIVE
Seen-on-STAGING
Seen-on-LIVE
and removed
Pending-on-STAGING
Pending-on-LIVE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560
Before we tried to run validation tasks for ALL the patients in parallel, using a task group for each patient.
That led to HTTPX pool timeouts with real data - the default is 5 seconds.
This rearranges the async handling to do bounded parallelism at the patient level - ie only handle max 5 patients in flight at once.
The old task group was actually redundant as we now parallelise lookups in external_patient_validators and external_visit_validators using asyncio.gather