Don't raise error on invalid dates in CSV uploads #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarton
added
Pending-on-STAGING
Pending-on-LIVE
Seen-on-STAGING
Seen-on-LIVE
and removed
Pending-on-STAGING
Pending-on-LIVE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #569 where I made it throw errors if the dates were invalid. Unfortunately the same live file I'm testing has a totally invalid date in one of the cells, not just the short year format.
So this PR changes us back to
errors=coerceand adds unit tests that bad date input crashes writing that patient to the database but doesn't tank the CSV upload.