Fix controls for CSV submission #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug where we were not showing correct controls for CSV submissions in 2023
I suspect not required since we started doing a full page refresh after changing the filters
mbarton
commented
Feb 12, 2025
| can_upload_csv = True | ||
| can_complete_questionnaire = True | ||
|
|
||
| audit_year = get_current_audit_year() |
There was a problem hiding this comment.
This was the buggy line - it didn't respect selected_audit_year
mbarton
added
Pending-on-STAGING
Pending-on-LIVE
Seen-on-STAGING
Seen-on-LIVE
and removed
Pending-on-STAGING
Pending-on-LIVE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593 where we were not showing correct controls for CSV submissions in 2023.
I've centralised the multiple functions we had for updating the session filters into one single place to hopefully make it less likely that future refactors introduce bugs.