Second-stick-of-celery #650
Open
+2,395
−744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_RESULT_BACKEND in .env
…of whining into the void
… allow rows to save with correct types
…submission creation still needs tweaking
…ritical error, permit all others if do not prevent save. Now 11 failing tests only
…saving. tests updated to reflect this.
|
Just to say these tests are all passing, so this must be to do with the configuration, maybe the environment variables not existing in the action. There are 4 tests that I have skipped which cover missing header name errors of various types. This is because the |
|
ok, the remaining tests are rewritten and tests now passing. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements celery / redis / celery beat
Adds 3 new containers so requires update to env
Will need similar changes within azure before merging
removes the async functions in the csv_upload function but leaves in the async API calls to other services