-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace findthatpostcode with our own self-hosted postcodes.io #1096
Comments
Note the docs need updating when this change is made: https://github.com/rcpch/rcpch-audit-engine/pull/1105/files/3fb2de2aa0a0f48b118dc4c4bf932a2686b15b1d#r1867521080 |
I've seen a couple of cases over the past 24 hours where correct postcodes are rejected because findthatpostcode returns a 429 Too Many Requests |
Bumping the priority of this as I've seen another 429 this morning. It would also "fix" #1173 for future patients by disallowing Looking at the error message the free allocation is per day, so we might be stuck all day now? |
postcodes.io does have a terminated postcode search that returns geo coordinates so for retired postcodes we could get the IMD that way |
We have noticed variable performance on findthatpostcode.uk, sometimes up to 10 seconds for a single request. This is fine because we are of course not paying for it! However in practice that's likely to be too slow for our users.
We have discussed creating a self-hosted instance of postcodes.io. We moved away from that provider as it seemed less up to date than findthatpostcode but since then they have made multiple releases and should now be up to date as of August 2024.
It's now up and running at https://api.rcpch.ac.uk/postcodes (API key required).
We will migrate in two steps
That way we're rollback safe and won't immediately break everyones local dev environments.
IMPORTANT - we need to discuss how to handle retired postcodes (3 examples in cohort 6).
The text was updated successfully, but these errors were encountered: