Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index of multiple deprivation missing for postcodes mispelt with O instead of zero #1173

Open
mbarton opened this issue Jan 15, 2025 · 2 comments

Comments

@mbarton
Copy link
Member

mbarton commented Jan 15, 2025

Create a new patient with the postcode SE12 OTX. Must use the letter O, not the number zero (which is technically correct).

We get a 500 error calling the IMD endpoint and the patient ends up without one:

django-1 | ERROR [epilepsy12.general_functions.index_multiple_deprivation:32] Could not get deprivation score for M16OEW. Response status 500

Note that 500 error is also what you get from the IMD endpoint for a postcode that doesn't exist, so I think it's probably a lookup issue.

We still use findthatpostcode (see #1096) which is forgiving of this very common formatting error. Unfortunately postcodes.io is not but I don't think it matters as they can just change the postcode during submission.

There are 10 examples in live.

@mbarton mbarton added priority: high High Priority Work - Max 3 Items and removed priority: high High Priority Work - Max 3 Items labels Jan 15, 2025
@mbarton mbarton added the priority: high High Priority Work - Max 3 Items label Jan 17, 2025
@mbarton
Copy link
Member Author

mbarton commented Jan 20, 2025

We've manually fixed the cohort 6 entries for this to unblock data analysis. Moving to postcodes.io would fix this issue as they reject the mispelt postcode. However it doesn't handle retired postcodes (see the comment in #1096 (comment))

@mbarton mbarton closed this as completed Jan 20, 2025
@mbarton mbarton removed the priority: high High Priority Work - Max 3 Items label Feb 15, 2025
@mbarton
Copy link
Member Author

mbarton commented Feb 15, 2025

Reopening as we've had another one of these come in

@mbarton mbarton reopened this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant