Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github workflow to validate PRs #560

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

elsassph
Copy link
Contributor

@elsassph elsassph commented Jan 28, 2025

Some recent-ish changes broke the (rare) unit tests.

Here's a workflow.

PS: there are visual tests which could also be run, but they are currently failing

Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@wouterlucas wouterlucas merged commit 8e9b510 into rdkcentral:dev Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants