Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playwright browser tests #561

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

elsassph
Copy link
Contributor

Fix browser tests

Some Mocha browser tests were present in the repository - however they wouldn't work in their current state:

  • HTML page referenced incorrect Lightning runtime,
  • Some Flexbox tests would not pass; it may be that Lightning engine diverged a little bit from HTML flexbox which was used as reference. I added a workaround to ignore divergences.

Added Playwright

Added an automation script to run those browser tests.

This required to adjust the Mocha tests because:

  • All the Mocha tests were running in a way hard to track with Playwright,
  • The tests create many Lightning stages which never stop running, which would be very heavy for CI; now the stages are stopped after the tests end.

Added Playwright CI check

Playwright tests now run as part of CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant