Skip to content

Address data validity assumption feedback for Bluetooth persistent store#44

Draft
Copilot wants to merge 17 commits into
developfrom
copilot/sub-pr-35-one-more-time
Draft

Address data validity assumption feedback for Bluetooth persistent store#44
Copilot wants to merge 17 commits into
developfrom
copilot/sub-pr-35-one-more-time

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 16, 2026

Responding to feedback on PR #35 regarding validation in BluetoothDeviceManager::updateBluetoothDeviceInfoCache().

Resolution

No code changes required. The current implementation correctly assumes data validity when reading from persistent store:

JsonArray deviceInfoArray;
deviceInfoArray.FromString(bluetoothDeviceInfoStr);

_adminLock.Lock();
_bluetoothDeviceInfoCache.clear();

for (uint16_t i = 0; i < deviceInfoArray.Length(); i++) {
    JsonObject deviceInfoObj = deviceInfoArray[i].Object();
    std::string deviceID = deviceInfoObj["deviceID"].String();
    // ... populate cache directly
}

Since BluetoothDeviceManager is the sole reader/writer of this persistent store namespace, extensive parse/shape validation is unnecessary.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on Bluetooth plug-in enhancements Address data validity assumption feedback for Bluetooth persistent store Feb 16, 2026
Copilot AI requested a review from pahearn73 February 16, 2026 15:58
@pahearn73 pahearn73 force-pushed the feature/RDKEMW-13334 branch 2 times, most recently from b395ace to 56a3106 Compare March 3, 2026 16:01
@pahearn73 pahearn73 force-pushed the feature/RDKEMW-13334 branch 3 times, most recently from 4b6909b to baad22d Compare March 11, 2026 00:04
@pahearn73 pahearn73 force-pushed the feature/RDKEMW-13334 branch from 4039c7c to 4fcf9e6 Compare March 13, 2026 15:29
Base automatically changed from feature/RDKEMW-13334 to develop March 13, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants