RDKEMW-18857 : Remove RDKCM_RDKE from all workflows#75
Open
balav08 wants to merge 1 commit into
Open
Conversation
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private. Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows. Test Procedure: refer ticket. Risks: Medium Priority: P2 version: Patch Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes usage of the RDKCM_RDKE secret from GitHub Actions workflows now that entservices-testframework is public, aiming to simplify workflow configuration and avoid relying on an unnecessary secret.
Changes:
- Removed passing
RDKCM_RDKEinto the reusable L1 test workflow trigger. - Removed an override that mapped
RDKCM_RDKEintoGITHUB_TOKENfor the native full build job. - Updated the component release workflow to clone without embedding
RDKCM_RDKEin the clone URL.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/tests-trigger.yml | Stops passing RDKCM_RDKE into the called L1 workflow. |
| .github/workflows/native_full_build.yml | Removes GITHUB_TOKEN env override that previously came from RDKCM_RDKE. |
| .github/workflows/L1-tests.yml | Removes workflow_call secret requirement and a commented token reference. |
| .github/workflows/component-release.yml | Removes RDKCM_RDKE from the git clone URL used in the release job. |
| run: | | ||
| set -e | ||
| git clone https://x-access-token:${{ secrets.RDKCM_RDKE }}@github.com/${{ github.repository }} project | ||
| git clone https://github.com/${{ github.repository }} project |
Comment on lines
3
to
9
| on: | ||
| workflow_call: | ||
| inputs: | ||
| caller_source: | ||
| description: "Specifies the source type (e.g., local or test framework) for the workflow." | ||
| required: true | ||
| type: string |
Comment on lines
203
to
204
| run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private.
Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows.
Test Procedure: refer ticket.
Risks: Medium
Priority: P2
version: Patch