Skip to content

Fix TOCTOU in lm_main.c #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdkdevpilot wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −9
Open

Fix TOCTOU in lm_main.c #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions source/lm/lm_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,19 +809,19 @@ static void LM_SET_ACTIVE_STATE_TIME_(int line, LmObjectHost *pHost,BOOL state){
{
if(pHost->bNotify == FALSE)
{
if(access("/tmp/.conn_cli_flag", F_OK) != 0)
{
/* CID :257716 Resource leak */
int fd;
/* CID 257720 Time of check time of use */
if ((fd = open("/tmp/.conn_cli_flag", O_CREAT | O_EXCL | O_WRONLY, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH | O_CLOEXEC)) >= 0)
/* CID :257716 Resource leak, CID 257720 Time of check time of use */
int fd = open("/tmp/.conn_cli_flag", O_CREAT | O_EXCL | O_WRONLY, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH | O_CLOEXEC);
if (fd >= 0)
{
close(fd);
}
get_uptime(&uptime);
CcspTraceWarning(("Client_Connect_complete:%d\n",uptime));
OnboardLog("Client_Connect_complete:%d\n",uptime);
t2_event_d("btime_clientconn_split", uptime);
if (fd >= 0) {
get_uptime(&uptime);
CcspTraceWarning(("Client_Connect_complete:%d\n",uptime));
OnboardLog("Client_Connect_complete:%d\n",uptime);
t2_event_d("btime_clientconn_split", uptime);
}
}
CcspTraceWarning(("RDKB_CONNECTED_CLIENTS: Client type is %s, MacAddress is %s and HostName is %s Connected \n",interface,pHost->pStringParaValue[LM_HOST_PhysAddressId],pHost->pStringParaValue[LM_HOST_HostNameId]));
lmHosts.lastActivity++;
Expand Down
Loading