RDKEMW-19048: META_PATCHSET build input (rebased on develop tip)#4177
Open
sergiygladkyy wants to merge 2 commits into
Open
RDKEMW-19048: META_PATCHSET build input (rebased on develop tip)#4177sergiygladkyy wants to merge 2 commits into
sergiygladkyy wants to merge 2 commits into
Conversation
…om build Reason for change: - Pin entservices-cryptography SRCREV to PR #10 head (db7b7d96) so develop custom builds pick up the CryptographyExtAccess SecAPI handle release fix paired with the vault_processor_release wrapper added by the preceding commit (RDKEMW-19048 bbappend on wpeframework-clientlibraries r4.4) - Code PR: rdkcentral/entservices-cryptography#10 - RM should redo this bump cleanly once #10 merges and is tagged Test Procedure: described in the ticket Implements: recipe SRCREV bump for develop custom build Risks: No Source: COMCAST License: Apache-2.0 Upstream-Status: Pending Version: patch Signed-off-by: Sergiy Gladkyy <sgladkyy@productengine.com>
1 task
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR provides a temporary Yocto “META_PATCHSET” input for an internal develop-branch build related to RDKEMW-19048, bundling a clientlibraries patch (to expose ProcessorRelease() via a C ABI wrapper) together with an entservices-cryptography SRCREV pin to a specific upstream PR head commit.
Changes:
- Add a new
wpeframework-clientlibrariesr4.4 patch that introducesvault_processor_release()inSecApi/Vault.cpp. - Include the new patch in
wpeframework-clientlibraries_4.4.bbSRC_URI. - Pin
entservices-cryptography.bbSRCREVto entservices-cryptography PR #10 head commit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| recipes-extended/wpe-framework/wpeframework-clientlibraries/r4.4/0002-RDKEMW-18043-Add-vault_processor_release-C-wrapper.patch | Adds a C ABI wrapper intended to release the Vault SecProcessor handle prior to deep sleep. |
| recipes-extended/wpe-framework/wpeframework-clientlibraries_4.4.bb | Applies the new patch in the r4.4 clientlibraries recipe. |
| recipes-extended/entservices/entservices-cryptography.bb | Pins SRCREV to a specific upstream PR head SHA for build input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+31
| + VaultImplementation* impl = vault_instance(CRYPTOGRAPHY_VAULT_DEFAULT); | ||
| + if (impl != nullptr) { | ||
| + reinterpret_cast<Implementation::Vault*>(impl)->ProcessorRelease(); | ||
| + } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway META_PATCHSET base for the RDKEMW-19048 develop AMLOGIC custom IA build. Not for merge.
Rebased on current develop tip (
3dc0008d), which matches the IA manifest pin formeta-rdk-videoinrdkcentral/rdke-middleware-generic-manifest:middleware-generic.xml. Earlier attempts (#4173 stacked on develop tipa8f49eaa; #4176 stacked on PR #3629 tip5643b5a6) used stale bases and are superseded.Contains two commits on top of develop:
bfa7d35d- submission RDKEMW-19048: Add vault_processor_release C wrapper to clientlibraries r4.4 #4172 (vault_processor_release C wrapper bbappend)1cbb5582- SRCREV bump for entservices-cryptography to PR RDKEMW-2278 : Removal of WPEFrameworkSecurity Agent Utility & related… #10 head (db7b7d96)Once submissions #4172 and entservices-cryptography #10 merge and tag, RM will redo the bumps cleanly off the released tags and this PR can be closed.