RDKEMW-23786: Fix A/V freezes during progressive playback - #5209
Open
asurdej-comcast wants to merge 1 commit into
Open
RDKEMW-23786: Fix A/V freezes during progressive playback#5209asurdej-comcast wants to merge 1 commit into
asurdej-comcast wants to merge 1 commit into
Conversation
Increase minimum queue size for small media files to reduce network reqests interrupts
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WPE WebKit 2.46.2 Yocto recipe to apply a new downstream patch that increases the effective buffering thresholds in webkitwebsrc, aiming to reduce pause/resume cycles (and resulting A/V freezes) during progressive playback of small-ish media resources.
Changes:
- Bump
WPE_RECIPE_REVISIONto pick up a new downstream change. - Add and apply a new patch (
1720_webkitwebsrc_queue_size.patch) adjustingwebkitwebsrcqueue watermark behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipes-extended/wpe-webkit/wpe-webkit_2.46.2.bb | Bumps recipe revision and adds the new patch to SRC_URI. |
| recipes-extended/wpe-webkit/files/2.46.2/1720_webkitwebsrc_queue_size.patch | Implements a minimum queue high watermark to reduce frequent download pause/resume cycles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+30
to
+35
| +// Keep at most 2% of the full media resource buffered or 2MB for small files (<100MB). | ||
| +// When this threshold is reached, the download task is paused. | ||
| +// For files smaller than MIN_QUEUE_HIGH_WATERMARK, downloading won't be paused. | ||
| #define HIGH_QUEUE_FACTOR_THRESHOLD 0.02 | ||
| +#define MIN_QUEUE_HIGH_WATERMARK (2 * 1024 * 1024) | ||
|
|
Comment on lines
+112
to
+116
| if (!members->haveSize || members->size != length) { | ||
| members->haveSize = true; | ||
| members->size = length; | ||
| + members->queueHighWatermark = std::max<size_t>(length * HIGH_QUEUE_FACTOR_THRESHOLD, MIN_QUEUE_HIGH_WATERMARK); | ||
| } |
|
CCI-Build-Verified +1 |
|
CCI-Test-Verified +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase minimum queue size for small media files to reduce network reqests interrupts