RDKEMW-0000 DO NOT MERGE, JUST For TEST - #5217
Open
vjain008 wants to merge 2 commits into
Open
Conversation
Reason for change : Fix window.location clobbering in NativeJSRenderer to preserve origin fields for ad requests Test Procedure: DO NOT MERGE, JUST For TEST Risks: Medium Priority: P1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto/BitBake recipe for rdknativescript to fetch a different upstream revision (via SRC_URI/branch and SRCREV), presumably to pull in the NativeJSRenderer fix referenced in the PR description.
Changes:
- Point
SRC_URIat a specific branch (test_rdkmw_23773) usingprotocol=${CMF_GITHUB_PROTOCOL}. - Update
SRCREVto a new commit SHA.
Suppressed comments (1)
recipes-graphics/rdknativescript/rdknativescript_git.bb:22
PV/the#Release 2.0.8note no longer clearly matches the source being fetched (test branch + updatedSRCREV). If this is meant to pull in a post-2.0.8 fix, consider bumpingPV/PR(or adjusting the release comment) so downstreams can identify that this recipe is not the original 2.0.8 release revision.
#Release 2.0.8
SRCREV = "d08f9ba58a1bedc93a02059f6d81f56a7c784aa8"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| PR = "r0" | ||
|
|
||
| SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX};" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;protocol=${CMF_GITHUB_PROTOCOL};branch=test_rdkmw_23773" |
|
CCI-Build-Verified +1 |
|
CCI-Test-Verified +1 |
Reason for change : FW changes Test Procedure: DO NOT MERGE, JUST For TEST Risks: Medium Priority: P1
Comment on lines
+19
to
+22
| SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;protocol=${CMF_GITHUB_PROTOCOL};branch=fix/freewheel-xhr-location-compliance" | ||
|
|
||
| #Release 2.0.8 | ||
| SRCREV = "13753ca4ece16d2225d44be52c64109d7ce2d307" | ||
| SRCREV = "63db7f59be2d511654a59bcd620f1777a1ebeb9d" |
|
CCI-Build-Verified +1 |
|
CCI-Test-Verified -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : Fix window.location clobbering in NativeJSRenderer to preserve origin fields for ad requests
Test Procedure: DO NOT MERGE, JUST For TEST
Risks: Medium
Priority: P1