RDK-61898: Internet Status Publishing in Deep Sleep Scenarios - #340
Open
cmuhammedrafi wants to merge 5 commits into
Open
RDK-61898: Internet Status Publishing in Deep Sleep Scenarios#340cmuhammedrafi wants to merge 5 commits into
cmuhammedrafi wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates NetworkManager’s connectivity monitoring behavior to ensure Internet connectivity status is re-published after waking from Deep Sleep, covering both Network Standby OFF and ON scenarios.
Changes:
- Trigger
connectivityMonitor.switchToInitialCheck()on DeepSleep → Standby wake paths (standby OFF via pre-change, standby ON via changed event). - Update connectivity monitor signaling/logging to tolerate an unset default interface (log
"none"instead of bailing out). - Reduce unnecessary periodic wakeups by idling indefinitely when fully connected until a wake-up signal arrives.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugin/NetworkManagerImplementation.cpp | Triggers connectivity re-check on DeepSleep wake to re-publish Internet status (standby OFF/ON paths). |
| plugin/NetworkManagerConnectivity.cpp | Adjusts switch-to-initial behavior and adds an infinite idle wait when fully connected, waking only on signals. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| { | ||
| NMLOG_INFO("connectivity monitor received signal. skipping %d sec interval", timeoutInSec); | ||
| std::unique_lock<std::mutex> lock(m_cmMutex); | ||
| NMLOG_INFO("ideal thread infinite wait strted while fully connected"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDK-61898: Internet Status Publishing in Deep Sleep Scenarios
Reason for change: code changes for publish Internet connectivity status during deepsleep wake up case