Fix GetServURL unit tests for new isSecureDbgSrvUnlocked logic#214
Draft
Copilot wants to merge 3 commits into
Draft
Fix GetServURL unit tests for new isSecureDbgSrvUnlocked logic#214Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…ked logic Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] [RDKEMW-15146] Address feedback on debug service unlock mechanism
Fix GetServURL unit tests for new isSecureDbgSrvUnlocked logic
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing
GetServURLunit tests assumed VBN builds and any PROD+debug-enabled build could use state-red/swupdate overrides. The newisSecureDbgSrvUnlockedlogic restricts this: onlyeDEV(always) andePRODwith all three conditions met (dbgServices=true + deviceType="test" + LABSIGNED_ENABLED=true) are unlocked.Existing tests fixed
isDebugServicesEnabledandfilePresentCheckmock expectations — VBN is neithereDEVnorePROD, soisSecureDbgSrvUnlockedreturns false immediately. Tests now expect TR181 recovery/autoexclude fallback viaread_RFCProperty.getDeviceTypeRFC("test") andgetDevicePropertyData("true") expectations to satisfy the full three-condition unlock check.getDeviceTypeRFC/getDevicePropertyDataexpectations (default/empty values, unlock still fails correctly).New tests added
Dev_StateredURL/Dev_SwupdateURLProd_NoLabsigned_StateredFallbackLABSIGNED_ENABLED=falseProd_WrongDeviceType_StateredFallbackdeviceType="production"Prod_PropertyDataFail_StateredFallbackgetDevicePropertyDatafailureQA_SwupdateFallback✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.