Fix stale GetServURL mock expectations and add isSecureDbgSrvUnlocked unit tests#217
Draft
Copilot wants to merge 2 commits into
Draft
Fix stale GetServURL mock expectations and add isSecureDbgSrvUnlocked unit tests#217Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ations Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on debug service unlock mechanism
Fix stale GetServURL mock expectations and add isSecureDbgSrvUnlocked unit tests
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isSecureDbgSrvUnlocked()PROD path checks three conditions (isDebugServicesEnabled(),getDeviceTypeRFC(),LABSIGNED_ENABLED), but existingGetServURLGTests only mocked the first, leaving the PROD+enabled tests silently broken and missing coverage for the new gating logic.Fixes to existing tests
isDebugServicesEnabled().Times(1)expectations — non-PROD builds short-circuit totruebefore reaching that call.getDeviceTypeRFCandgetDevicePropertyDatamock expectations (returning"test"/"true"/UTILS_SUCCESS) soisSecureDbgSrvUnlocked(ePROD)actually unlocks and the conf-file URL path is taken.dbgServices=falsealone locks the build, eliminating unregistered-call warnings.New isSecureDbgSrvUnlocked unit tests
Six focused tests exercising each input independently:
IsSecureDbgSrvUnlocked_NonProdBuild_ReturnsTrueeVBNtrueIsSecureDbgSrvUnlocked_Prod_AllConditionsMet_ReturnsTruedbgServices=true,deviceType="test",labsigned="true"trueIsSecureDbgSrvUnlocked_Prod_DebugServicesDisabled_ReturnsFalsedbgServices=falsefalseIsSecureDbgSrvUnlocked_Prod_WrongDeviceType_ReturnsFalsedeviceType="prod"falseIsSecureDbgSrvUnlocked_Prod_LabsignedFalse_ReturnsFalselabsigned="false"falseIsSecureDbgSrvUnlocked_Prod_LabsignedPropertyFailed_ReturnsFalsegetDevicePropertyData()returns-1false📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.