Add unit tests for getDeviceTypeRFC()#220
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
…od, test, and unknown cases Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on unlocking debug service mechanism
Add unit tests for getDeviceTypeRFC()
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDeviceTypeRFC()introduced RFC-to-device-type mapping logic ("prod","test","unknown") with no unit test coverage. Adds tests tofwdl_interface_gtest.cppusing the existingInterfaceTestFixtureandg_InterfaceMock.New tests
TestName_getDeviceTypeRFCReadFailure—getRFCParameterreturnsWDMP_FAILURE; expects"unknown"TestName_getDeviceTypeRFCProd— RFC value"prod", expects"prod"TestName_getDeviceTypeRFCTest— RFC value"test", expects"test"TestName_getDeviceTypeRFCUnknown— Unrecognized RFC value ("staging"), expects"unknown"Invokelambdas overrideparam->valueto inject specific RFC strings through the existing mock chain:Also adds a
.gitignoreto prevent autotools/build artifacts from polluting future commits.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.