DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark#6389
Merged
Conversation
Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com>
npoltorapavlo
force-pushed
the
DELIA-68911
branch
from
3b7f2fd to
c83f7b8
Compare
anand-ky
approved these changes
Sep 23, 2025
npoltorapavlo
added a commit
to npoltorapavlo/rdkservices
that referenced
this pull request
Sep 30, 2025
…al#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
anand-ky
added a commit
that referenced
this pull request
Sep 30, 2025
* DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
npoltorapavlo
added a commit
to npoltorapavlo/rdkservices
that referenced
this pull request
Oct 3, 2025
* DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (rdkcentral#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
anand-ky
added a commit
that referenced
this pull request
Oct 3, 2025
* Delia 68911 main (#6396) * DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com> * Delia 69034 main (#6404) * DELIA-69034 : handling errors for content protection service (#6387) Reason for change: Add mapping for Invalid aspect dimension, and Watermark perceptibility errors. Fix mapping for DRM entitlement error. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * RDKEMW-8549 : handling errors for content protection service (#6392) Reason for change: Typo fix. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
npoltorapavlo
added a commit
to npoltorapavlo/rdkservices
that referenced
this pull request
Oct 7, 2025
* DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (rdkcentral#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
anand-ky
added a commit
that referenced
this pull request
Oct 8, 2025
* RDK-58380 DELIA-68566 : A-sync Dispatch instead of sync Invoke for JSON-RPC (#6328) (#6351) * RDK-58380 : A-sync Dispatch instead of sync Invoke for JSON-RPC (#6328) * Tidy up yml workflow file * Fix format specifiers * RDK-58380 : More checks / logs for ContentProtection service Reason for change: For all events, check Ids are relevant to ContentProtection, and ignore otherwise. For all json-rpc, log return code on failure, to indicate timeouts or other issues. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> * RDK-58380 : A-sync Dispatch instead of sync Invoke for JSON-RPC Reason for change: JSONRPC Invoke from event handler is timing out when sending the call. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Srikanth <107277821+srikanth-vv@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Srikanth <107277821+srikanth-vv@users.noreply.github.com> * Delia 68911 main (#6396) * DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com> * Delia 69034 main (#6404) * DELIA-69034 : handling errors for content protection service (#6387) Reason for change: Add mapping for Invalid aspect dimension, and Watermark perceptibility errors. Fix mapping for DRM entitlement error. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * RDKEMW-8549 : handling errors for content protection service (#6392) Reason for change: Typo fix. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Srikanth <107277821+srikanth-vv@users.noreply.github.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
npoltorapavlo
added a commit
to npoltorapavlo/rdkservices
that referenced
this pull request
Oct 13, 2025
* DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (rdkcentral#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
srikanth-vv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Delia 68911 main (#6396) * DELIA-68911 : Send no "clutSize" in modifyPalettedWatermark (#6389) Reason for change: Skip palette size parameter. Because of watermark plugin, which by default having logic that works for palette size of 256*4. When same watermark plugin is interacted from aamp instead of content protection, palette size parameter is not passed and defaulted to 256*4 inside watermark plugin. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com> * Delia 69034 main (#6404) * DELIA-69034 : handling errors for content protection service (#6387) Reason for change: Add mapping for Invalid aspect dimension, and Watermark perceptibility errors. Fix mapping for DRM entitlement error. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> * RDKEMW-8549 : handling errors for content protection service (#6392) Reason for change: Typo fix. Test Procedure: None Risks: None Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> * update changelog and api version --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> --------- Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com> Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Skip palette size parameter.
Because of watermark plugin, which
by default having logic that works for
palette size of 2564. When same watermark
plugin is interacted from aamp instead of
content protection, palette size parameter
is not passed and defaulted to 2564 inside
watermark plugin.
Test Procedure: None
Risks: None