RDK-61088: Replace vendor reboot reason script from shell to C by INajeemaBegam · Pull Request #43 · rdkcentral/reboot-manager

INajeemaBegam · 2026-05-11T07:55:54Z

Reason for change: Added code for Reboot reason
Test Procedure: None
Risks: P1
Signed-off-by: najeemabegami najeemabegam.iqbal@sky.uk

Copilot

Pull request overview

This PR updates the reboot-reason fetcher API by simplifying get_hardware_reason() to no longer take a RebootInfo*, and updates the in-tree call sites/tests accordingly.

Changes:

Changed get_hardware_reason() signature to accept only (const EnvContext*, HardwareReason*).
Updated update-prev-reboot-info main flow and the gtest call sites to use the new signature.
Adjusted argument validation/logging in get_hardware_reason() to match the new parameters.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`unittest/reboot_log_parser_gtest.cpp`	Updates unit tests to call the new `get_hardware_reason()` signature (but leaves some now-misleading assertions).
`reboot-reason-fetcher/src/rebootreason_main.c`	Updates the production call site to the new signature.
`reboot-reason-fetcher/src/log_parser.c`	Updates the `get_hardware_reason()` definition and its argument validation/logging.
`reboot-reason-fetcher/include/update-reboot-info.h`	Updates the exported header declaration for the new function signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 int parse_device_properties(EnvContext *ctx);
 void free_env_context(EnvContext *ctx);
-int get_hardware_reason(const EnvContext *ctx, HardwareReason *hwReason, RebootInfo *info);
+int get_hardware_reason(const EnvContext *ctx, HardwareReason *hwReason);



        RDK_LOG(RDK_LOG_DEBUG,"LOG.RDK.REBOOTINFO","Getting hardware reboot reason for current boot \n");
-        get_hardware_reason(&ctx, &hwReason, &rebootInfo);
+        get_hardware_reason(&ctx, &hwReason);


+    EXPECT_EQ(get_hardware_reason(&ctx, &hw), SUCCESS);
    EXPECT_STREQ(hw.mappedReason, "UNKNOWN");
    EXPECT_EQ(info.reason[0], '\0');
 }


    strncpy(info.timestamp, "2026-03-10T11:22:33Z", sizeof(info.timestamp) - 1);

-    EXPECT_EQ(get_hardware_reason(&ctx, &hw, &info), SUCCESS);
+    EXPECT_EQ(get_hardware_reason(&ctx, &hw), SUCCESS);
    EXPECT_STREQ(hw.mappedReason, "UNKNOWN");
    EXPECT_EQ(info.reason[0], '\0');
    EXPECT_STREQ(info.timestamp, "2026-03-10T11:22:33Z");


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

unittest/reboot_log_parser_gtest.cpp:674

Same issue as the Amlogic variant: with the RebootInfo* parameter removed, this test’s assertions about info.reason/info.timestamp are no longer meaningful, and the mocked MTK sysfs file isn’t used by get_hardware_reason. Adjust the test to validate the MTK read/mapping behavior via hw (or drop/rename the test if MTK support was intentionally removed from get_hardware_reason).

TEST_F(LogParserTest, get_hardware_reason_DispatchMtkUsesReadPath) {
    setupMockFile("/sys/mtk_pm/boot_reason", "/tmp/reboot_test/mtk_sysfs", "0xD1\n");
    g_mock_fs_enabled = true;

    EnvContext ctx;
    HardwareReason hw;
    RebootInfo info;
    memset(&ctx, 0, sizeof(ctx));
    memset(&hw, 0, sizeof(hw));
    memset(&info, 0, sizeof(info));
    set_hal_test_soc(&ctx, HalTestSoc::Mediatek);
    strncpy(info.timestamp, "2026-03-10T11:22:33Z", sizeof(info.timestamp) - 1);

    EXPECT_EQ(get_hardware_reason(&ctx, &hw), SUCCESS);
    EXPECT_STREQ(hw.mappedReason, "UNKNOWN");
    EXPECT_EQ(info.reason[0], '\0');
    EXPECT_STREQ(info.timestamp, "2026-03-10T11:22:33Z");

      utils.c

-librebootnow_la_LIBADD = -lfwutils -lrdkloggers -lrfcapi -lsecure_wrapper
+librebootnow_la_LIBADD = -lfwutils -lrdkloggers -lrfcapi -lsecure_wrapper -lrebootreason


 rebootnow_LDADD = librebootnow.la

-AM_LDFLAGS = -lrdkloggers -lfwutils -lrfcapi -lsecure_wrapper
+AM_LDFLAGS = -lrdkloggers -lfwutils -lrfcapi -lsecure_wrapper #-lrebootreason


 TEST_F(LogParserTest, get_hardware_reason_DispatchAmlogicUsesReadPath) {
    setupMockFile("/sys/devices/platform/aml_pm/reset_reason", "/tmp/reboot_test/amlogic_sysfs", "12\n");
    g_mock_fs_enabled = true;

    EnvContext ctx;
    HardwareReason hw;
    RebootInfo info;
    memset(&ctx, 0, sizeof(ctx));
    memset(&hw, 0, sizeof(hw));
    memset(&info, 0, sizeof(info));
    set_hal_test_soc(&ctx, HalTestSoc::Amlogic);

-    EXPECT_EQ(get_hardware_reason(&ctx, &hw, &info), SUCCESS);
+    EXPECT_EQ(get_hardware_reason(&ctx, &hw), SUCCESS);
    EXPECT_STREQ(hw.mappedReason, "UNKNOWN");
    EXPECT_EQ(info.reason[0], '\0');


Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

@@ -48,13 +48,17 @@ update_prev_reboot_info_SOURCES = \
      $(top_srcdir)/reboot-reason-fetcher/src/parodus_log_update.c \
      $(top_srcdir)/reboot-reason-fetcher/src/bootup_reason_checker.c

+update_prev_reboot_info_la_LIBADD += -lrebootreason
+


 if USE_CPC
 update_prev_reboot_info_SOURCES += \
    $(srcdir)/rebootmanager-cpc/src/reboot_reason_classify.c \
    $(srcdir)/rebootmanager-cpc/src/platform_hal.c \
    $(srcdir)/rebootmanager-cpc/src/log_parser.c 
 update_prev_reboot_info_CPPFLAGS = \
    -I$(srcdir)/rebootmanager-cpc/include 
+
+update_prev_reboot_info_la_LIBADD = -lrebootreason
 else



-librebootnow_la_LIBADD = -lfwutils -lrdkloggers -lrfcapi -lsecure_wrapper
+librebootnow_la_LIBADD = -lfwutils -lrdkloggers -lrfcapi -lsecure_wrapper #-lrebootreason

 # CLI wrapper binary
 bin_PROGRAMS = rebootnow
 rebootnow_SOURCES = reboot_main.c
 rebootnow_LDADD = librebootnow.la

-AM_LDFLAGS = -lrdkloggers -lfwutils -lrfcapi -lsecure_wrapper
+AM_LDFLAGS = -lrdkloggers -lfwutils -lrfcapi -lsecure_wrapper #-lrebootreason



 int release_lock(const char *lockDir);
 int parse_device_properties(EnvContext *ctx);
 void free_env_context(EnvContext *ctx);
-int get_hardware_reason(const EnvContext *ctx, HardwareReason *hwReason, RebootInfo *info);
+int get_hardware_reason(const EnvContext *ctx, HardwareReason *hwReason);
 int read_brcm_previous_reboot_reason(HardwareReason *hw);


+##########################################################################
+# If not stated otherwise in this file or this component's LICENSE
+# file the following copyright and licenses apply:
+#
+# Copyright 2026 Comcast Cable Communications Management, LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##########################################################################
+
+AUTOMAKE_OPTIONS = foreign subdir-objects
+
+reboot_CFLAGS += -fPIC -pthread
+
+AM_CPPFLAGS = -I$(top_srcdir)/reboot-helper/include -I$(top_srcdir)/reboot-reason-fetcher/include
+AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -O2 -I./reboot-helper/include -DRDK_LOGGER_ENABLED -fPIC -pthread
+
+# Library target
+lib_LTLIBRARIES = librebootnow.la
+librebootnow_la_LDFLAGS = -shared
+librebootnow_la_SOURCES = \
+      system_cleanup.c \
+      cyclic_reboot.c \
+      utils.c
+
+librebootnow_la_LIBADD = -lfwutils -lrdkloggers -lrfcapi -lsecure_wrapper #-lrebootreason
+
+# CLI wrapper binary
+bin_PROGRAMS = rebootnow
+rebootnow_SOURCES = reboot_main.c
+rebootnow_LDADD = librebootnow.la
+
+AM_LDFLAGS = -lrdkloggers -lfwutils -lrfcapi -lsecure_wrapper #-lrebootreason
+
+bin_PROGRAMS += update-prev-reboot-info
+update_prev_reboot_info_SOURCES = \
+      $(top_srcdir)/reboot-reason-fetcher/src/rebootreason_main.c \
+      $(top_srcdir)/reboot-reason-fetcher/src/json.c \
+      $(top_srcdir)/reboot-reason-fetcher/src/parodus_log_update.c \
+      $(top_srcdir)/reboot-reason-fetcher/src/bootup_reason_checker.c
+
+update_prev_reboot_info_la_LIBADD += -lrebootreason
+
+if USE_CPC
+update_prev_reboot_info_SOURCES += \
+    $(srcdir)/rebootmanager-cpc/src/reboot_reason_classify.c \
+    $(srcdir)/rebootmanager-cpc/src/platform_hal.c \
+    $(srcdir)/rebootmanager-cpc/src/log_parser.c 
+update_prev_reboot_info_CPPFLAGS = \
+    -I$(srcdir)/rebootmanager-cpc/include 
+
+update_prev_reboot_info_la_LIBADD = -lrebootreason
+else
+update_prev_reboot_info_SOURCES += \
+      $(top_srcdir)/reboot-reason-fetcher/src/reboot_reason_classify.c \
+      $(top_srcdir)/reboot-reason-fetcher/src/log_parser.c 
+update_prev_reboot_info_CPPFLAGS = \
+      $(AM_CPPFLAGS) \
+      -I$(top_srcdir)/reboot-reason-fetcher/include
+endif
+
+if IS_TELEMETRY2_ENABLED
+   AM_CFLAGS +=  $(T2_EVENT_FLAG)
+   AM_LDFLAGS += -ltelemetry_msgsender -lt2utils
+endif


Reason for change: Added code for Reboot reason Test Procedure: None Risks: P1 Signed-off-by: najeemabegami <najeemabegam.iqbal@sky.uk>

Copilot AI review requested due to automatic review settings May 11, 2026 07:55

Copilot started reviewing on behalf of INajeemaBegam May 11, 2026 07:56 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

INajeemaBegam force-pushed the feature/RDK-61088-reboot-reason-common branch from dad4147 to 85e65f7 Compare May 20, 2026 07:15

Copilot AI review requested due to automatic review settings May 20, 2026 11:22

INajeemaBegam force-pushed the feature/RDK-61088-reboot-reason-common branch from 85e65f7 to 664741e Compare May 20, 2026 11:22

Copilot started reviewing on behalf of INajeemaBegam May 20, 2026 11:22 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

INajeemaBegam force-pushed the feature/RDK-61088-reboot-reason-common branch 2 times, most recently from edbc4e6 to ec30e74 Compare May 24, 2026 15:06

Copilot AI review requested due to automatic review settings May 24, 2026 15:06

Copilot started reviewing on behalf of INajeemaBegam May 24, 2026 15:07 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

RDK-61088: Replace vendor reboot reason script from shell to C

c4006be

Reason for change: Added code for Reboot reason Test Procedure: None Risks: P1 Signed-off-by: najeemabegami <najeemabegam.iqbal@sky.uk>

INajeemaBegam force-pushed the feature/RDK-61088-reboot-reason-common branch from ec30e74 to c4006be Compare May 25, 2026 03:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDK-61088: Replace vendor reboot reason script from shell to C#43

RDK-61088: Replace vendor reboot reason script from shell to C#43
INajeemaBegam wants to merge 1 commit into
mainfrom
feature/RDK-61088-reboot-reason-common

INajeemaBegam commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

INajeemaBegam commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants