Skip to content

RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C modue#44

Merged
nhanasi merged 6 commits into
developfrom
feature/RDKEMW-18591
May 22, 2026
Merged

RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C modue#44
nhanasi merged 6 commits into
developfrom
feature/RDKEMW-18591

Conversation

@madhubabutt
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings May 18, 2026 11:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how “PreviousRebootInfo” is written into Parodus-related logs/files and adjusts logging verbosity/messages in the reboot-reason-fetcher flow to provide different runtime visibility.

Changes:

  • Reorders PreviousRebootInfo fields to timestamp,custom,source,reason in multiple writers and updates unit test expectations accordingly.
  • Updates update_previous_reboot_info.sh Parodus log append format (including removing the /bin/timestamp + $0: prefix in one path).
  • Adds/adjusts several RDK_LOG messages and log levels in rebootreason_main.c, plus additional discovery logging in bootup_reason_checker.c.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
unittest/reboot_parodus_gtest.cpp Updates expected PreviousRebootInfo field ordering in unit tests.
scripts/update_previous_reboot_info.sh Changes Parodus log append lines and PreviousRebootInfo field ordering.
reboot-reason-fetcher/src/rebootreason_main.c Adds/changes informational logs and log levels during reboot reason processing.
reboot-reason-fetcher/src/parodus_log_update.c Changes PreviousRebootInfo formatting/order when updating parodus.log / fallback file output.
reboot-reason-fetcher/src/log_parser.c Lowers “STT flag missing” log from INFO to DEBUG.
reboot-reason-fetcher/src/bootup_reason_checker.c Adds log statements and changes fallback log messaging during previous reboot log discovery.
Comments suppressed due to low confidence (1)

reboot-reason-fetcher/src/parodus_log_update.c:160

  • The info->reason argument line is tab-indented, while surrounding lines use spaces. This introduces inconsistent formatting in this block; please convert the tab indentation to spaces to match the file’s style.
    fprintf(out, "PreviousRebootInfo:%s,%s,%s,%s\n",
            info->timestamp,
            info->customReason,
            info->source,
	    info->reason);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/update_previous_reboot_info.sh Outdated
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/parodus_log_update.c Outdated
Comment thread reboot-reason-fetcher/src/bootup_reason_checker.c
Comment thread scripts/update_previous_reboot_info.sh Outdated
Copilot AI review requested due to automatic review settings May 19, 2026 10:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Comment thread scripts/update_previous_reboot_info.sh Outdated
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/parodus_log_update.c
Copilot AI review requested due to automatic review settings May 22, 2026 06:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

reboot-reason-fetcher/src/parodus_log_update.c:82

  • update_parodus_log() now writes Parodus log lines as "<ts> <component>: ...", but handle_parodus_reboot_file() still writes "<ts>: <component>: ..." (see same file around lines 135-136). This produces mixed log formats in the same log file; consider standardizing on one format.
    fprintf(fp, "%s %s: Updating previous reboot info to Parodus\n", timestamp, "update_previous_reboot_info");
    fprintf(fp, "%s %s: PreviousRebootInfo:%s,%s,%s,%s\n",
            timestamp,
	    "update_previous_reboot_info",
            info->timestamp,
            info->reason,
            info->customReason,
            info->source);

Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread scripts/update_previous_reboot_info.sh
Comment thread reboot-reason-fetcher/src/parodus_log_update.c
@nhanasi nhanasi changed the title Updating log files RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C modue May 22, 2026
@nhanasi nhanasi merged commit b47e8c4 into develop May 22, 2026
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants