RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C modue#44
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how “PreviousRebootInfo” is written into Parodus-related logs/files and adjusts logging verbosity/messages in the reboot-reason-fetcher flow to provide different runtime visibility.
Changes:
- Reorders
PreviousRebootInfofields totimestamp,custom,source,reasonin multiple writers and updates unit test expectations accordingly. - Updates
update_previous_reboot_info.shParodus log append format (including removing the/bin/timestamp+$0:prefix in one path). - Adds/adjusts several
RDK_LOGmessages and log levels inrebootreason_main.c, plus additional discovery logging inbootup_reason_checker.c.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| unittest/reboot_parodus_gtest.cpp | Updates expected PreviousRebootInfo field ordering in unit tests. |
| scripts/update_previous_reboot_info.sh | Changes Parodus log append lines and PreviousRebootInfo field ordering. |
| reboot-reason-fetcher/src/rebootreason_main.c | Adds/changes informational logs and log levels during reboot reason processing. |
| reboot-reason-fetcher/src/parodus_log_update.c | Changes PreviousRebootInfo formatting/order when updating parodus.log / fallback file output. |
| reboot-reason-fetcher/src/log_parser.c | Lowers “STT flag missing” log from INFO to DEBUG. |
| reboot-reason-fetcher/src/bootup_reason_checker.c | Adds log statements and changes fallback log messaging during previous reboot log discovery. |
Comments suppressed due to low confidence (1)
reboot-reason-fetcher/src/parodus_log_update.c:160
- The
info->reasonargument line is tab-indented, while surrounding lines use spaces. This introduces inconsistent formatting in this block; please convert the tab indentation to spaces to match the file’s style.
fprintf(out, "PreviousRebootInfo:%s,%s,%s,%s\n",
info->timestamp,
info->customReason,
info->source,
info->reason);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
May 18, 2026 11:20
added 2 commits
May 21, 2026 07:50
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
reboot-reason-fetcher/src/parodus_log_update.c:82
update_parodus_log()now writes Parodus log lines as"<ts> <component>: ...", buthandle_parodus_reboot_file()still writes"<ts>: <component>: ..."(see same file around lines 135-136). This produces mixed log formats in the same log file; consider standardizing on one format.
fprintf(fp, "%s %s: Updating previous reboot info to Parodus\n", timestamp, "update_previous_reboot_info");
fprintf(fp, "%s %s: PreviousRebootInfo:%s,%s,%s,%s\n",
timestamp,
"update_previous_reboot_info",
info->timestamp,
info->reason,
info->customReason,
info->source);
nhanasi
approved these changes
May 22, 2026
nhanasi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.