RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C module#45
Open
Saranya2421 wants to merge 7 commits into
Open
RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C module#45Saranya2421 wants to merge 7 commits into
Saranya2421 wants to merge 7 commits into
Conversation
Migrate Reboot Checker script to reboot manager
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates reboot-reason logging to better align Parodus log timestamps between the shell script and C implementation, while also adjusting several log levels/messages for reboot processing visibility.
Changes:
- Switches some Parodus log timestamps to UTC ISO-8601-style formatting with milliseconds.
- Adjusts reboot reason fetcher log messages and log levels.
- Adds extra informational logging around lock handling, file discovery, and fallback log selection.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/update_previous_reboot_info.sh |
Updates Parodus log timestamp formatting in setPreviousRebootInfo(). |
reboot-reason-fetcher/src/rebootreason_main.c |
Adds/changes operational logging around reboot-info processing. |
reboot-reason-fetcher/src/parodus_log_update.c |
Updates C timestamp generation and Parodus log line formatting. |
reboot-reason-fetcher/src/log_parser.c |
Lowers missing STT flag log level from info to debug. |
reboot-reason-fetcher/src/bootup_reason_checker.c |
Adds/updates log messages for previous reboot log discovery. |
Comments suppressed due to low confidence (1)
reboot-reason-fetcher/src/parodus_log_update.c:91
- This updates only the
update_parodus_log()Parodus entries to the newtimestamp source:format, buthandle_parodus_reboot_file()still appends Parodus log lines astimestamp: source:using the same timestamp helper. Devices that go through the parodusreboot.info path will therefore continue to produce a different log format; update the other Parodus logfile writes as well so both C paths match the shell format.
fprintf(fp, "%s %s: Updating previous reboot info to Parodus\n", timestamp, "update_previous_reboot_info");
fprintf(fp, "%s %s: PreviousRebootInfo:%s,%s,%s,%s\n",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
reviewed
May 19, 2026
nhanasi
reviewed
May 19, 2026
added 2 commits
May 21, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.