Skip to content

RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C module#45

Open
Saranya2421 wants to merge 7 commits into
mainfrom
feature/RDKEMW-18591
Open

RDKEMW-18591: Reboot Reason log Timestamp missmatch in parodus logs with C module#45
Saranya2421 wants to merge 7 commits into
mainfrom
feature/RDKEMW-18591

Conversation

@Saranya2421
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 11:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates reboot-reason logging to better align Parodus log timestamps between the shell script and C implementation, while also adjusting several log levels/messages for reboot processing visibility.

Changes:

  • Switches some Parodus log timestamps to UTC ISO-8601-style formatting with milliseconds.
  • Adjusts reboot reason fetcher log messages and log levels.
  • Adds extra informational logging around lock handling, file discovery, and fallback log selection.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/update_previous_reboot_info.sh Updates Parodus log timestamp formatting in setPreviousRebootInfo().
reboot-reason-fetcher/src/rebootreason_main.c Adds/changes operational logging around reboot-info processing.
reboot-reason-fetcher/src/parodus_log_update.c Updates C timestamp generation and Parodus log line formatting.
reboot-reason-fetcher/src/log_parser.c Lowers missing STT flag log level from info to debug.
reboot-reason-fetcher/src/bootup_reason_checker.c Adds/updates log messages for previous reboot log discovery.
Comments suppressed due to low confidence (1)

reboot-reason-fetcher/src/parodus_log_update.c:91

  • This updates only the update_parodus_log() Parodus entries to the new timestamp source: format, but handle_parodus_reboot_file() still appends Parodus log lines as timestamp: source: using the same timestamp helper. Devices that go through the parodusreboot.info path will therefore continue to produce a different log format; update the other Parodus logfile writes as well so both C paths match the shell format.
    fprintf(fp, "%s %s: Updating previous reboot info to Parodus\n", timestamp, "update_previous_reboot_info");
    fprintf(fp, "%s %s: PreviousRebootInfo:%s,%s,%s,%s\n",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/parodus_log_update.c
Comment thread scripts/update_previous_reboot_info.sh Outdated
Comment thread scripts/update_previous_reboot_info.sh Outdated
Comment thread reboot-reason-fetcher/src/parodus_log_update.c Outdated
Copilot AI review requested due to automatic review settings May 22, 2026 06:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Comment thread scripts/update_previous_reboot_info.sh
Comment thread reboot-reason-fetcher/src/parodus_log_update.c
Comment thread reboot-reason-fetcher/src/parodus_log_update.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/rebootreason_main.c
Comment thread reboot-reason-fetcher/src/bootup_reason_checker.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants