Skip to content

Refactor TextTrackPluginWrapper to include module definition and headers in source file #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bramoosterhuis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor TextTrackPluginWrapper to include module definition and headers in source file #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions wrappers/include/TextTrackPluginWrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@
#ifndef FIREBOLT_RIALTO_WRAPPERS_TEXT_TRACK_PLUGIN_WRAPPER_H_
#define FIREBOLT_RIALTO_WRAPPERS_TEXT_TRACK_PLUGIN_WRAPPER_H_

#ifndef MODULE_NAME
#define MODULE_NAME TextTrackClosedCaptionsStyleClient
#endif

#include "ITextTrackPluginWrapper.h"
#include <com/com.h>
#include <core/core.h>
#ifdef RIALTO_ENABLE_TEXT_TRACK
#include <interfaces/ITextTrack.h>
#endif // RIALTO_ENABLE_TEXT_TRACK
Expand Down
7 changes: 7 additions & 0 deletions wrappers/source/TextTrackPluginWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,17 @@
* limitations under the License.
*/

#define MODULE_NAME TextTrackClosedCaptionsStyleClient

#include <com/com.h>
#include <core/core.h>

#include "TextTrackPluginWrapper.h"
#include "TextTrackPluginWrapperFactory.h"
#include "TextTrackWrapper.h"

MODULE_NAME_ARCHIVE_DECLARATION

namespace firebolt::rialto::wrappers
{
std::shared_ptr<ITextTrackPluginWrapper> TextTrackPluginWrapperFactory::getTextTrackPluginWrapper()
Expand Down
Loading