Feature/hdmi switch8.4 test

[balasaraswathy-n]

sleep for 1 sec and total wait for 4sec

[Copilot]

Pull request overview

This PR updates Rialto’s media pipeline and DRM/decryption flow to better handle HDMI/HDCP output restriction scenarios and to support reporting whether play() is synchronous vs asynchronous across the IPC boundary. It also refactors flush-on-preroll handling (moving state tracking to the dispatcher thread), adds audio typefind/parser relinking support, and updates a large set of unit/component tests accordingly.

Changes:

• Add OUTPUT_RESTRICTED retry handling in the decryption path (OpenCDM wrapper + MediaKeys retry loop).
• Extend play() API end-to-end to return an async flag (public API, IPC proto/service/client, mocks, tests).
• Refactor flush-on-preroll flow (new controller interface/impl, dispatcher-thread integration), plus related generic-player task/test updates.

Reviewed changes

Copilot reviewed 118 out of 118 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
wrappers/source/OcdmSession.cpp	Adds optional _decrypt_buffer_once path with pre/post key-status checks and debug logging.
wrappers/interface/IGstWrapper.h	Adds wrapper APIs for element state queries and pad/bin operations.
wrappers/include/OcdmSession.h	Declares new OpenCDM decrypt function pointer typedef/static.
wrappers/include/GstWrapper.h	Implements newly added IGstWrapper methods.
wrappers/CMakeLists.txt	Adds common/logging include directories to wrappers target.
serverManager/common/source/HealthcheckService.h	Changes failed-ping tracking from counter to per-pingId set.
serverManager/common/source/HealthcheckService.cpp	Handles “late ack” by removing specific pingId from failure set.
tests/unittests/serverManager/unittests/common/HealthcheckServiceTests.cpp	Adds coverage for “late ack” behavior.
proto/mediapipelinemodule.proto	Adds async field to PlayResponse and updates docstring.
media/public/include/MediaCommon.h	Adds MediaKeyErrorStatus::OUTPUT_RESTRICTED.
media/public/include/IMediaPipeline.h	Changes play() signature to play(bool &async).
media/server/service/include/IMediaPipelineService.h	Updates play() signature to include async out param.
media/server/service/source/MediaPipelineService.h	Updates service interface implementation signature.
media/server/service/source/MediaPipelineService.cpp	Propagates async out param down to pipeline implementation.
media/server/ipc/source/MediaPipelineModuleService.cpp	Sets PlayResponse.async based on server-side result.
media/client/ipc/interface/IMediaPipelineIpc.h	Updates IPC interface play() to include async out param.
media/client/ipc/include/MediaPipelineIpc.h	Updates IPC class interface accordingly.
media/client/ipc/source/MediaPipelineIpc.cpp	Reads PlayResponse.async into caller-provided out param.
media/client/main/include/MediaPipeline.h	Updates client MediaPipeline::play() signature.
media/client/main/source/MediaPipeline.cpp	Forwards async from client API to IPC.
media/client/main/include/MediaPipelineProxy.h	Updates proxy play() signature.
media/server/main/include/MediaPipelineServerInternal.h	Updates server internal play() signature and docs.
media/server/main/source/MediaPipelineServerInternal.cpp	Makes play() priority enqueue + removes gst-player call from removeSource.
media/server/main/source/MediaKeysServerInternal.cpp	Adds OUTPUT_RESTRICTED retry loop with 1s sleep, 4s total timeout + debug logs.
media/server/main/source/MediaKeysCapabilities.cpp	Adds OUTPUT_RESTRICTED to status-to-string mapping.
media/server/ipc/source/MediaKeysModuleService.cpp	Adds OUTPUT_RESTRICTED conversion case (currently TODO).
media/server/gstplayer/include/IFlushOnPrerollController.h	Replaces “postpone flush” API with wait/target-state based API.
media/server/gstplayer/include/FlushOnPrerollController.h	Adds condition-variable based controller state.
media/server/gstplayer/source/FlushOnPrerollController.cpp	Implements wait/setFlushing/prerolling/target-state transitions + logging.
media/server/gstplayer/include/IGstDispatcherThread.h	Passes flush controller into dispatcher thread factory.
media/server/gstplayer/include/GstDispatcherThread.h	Stores flush controller and updates constructor.
media/server/gstplayer/source/GstDispatcherThread.cpp	Updates factory + reports pipeline state changes to flush controller.
media/server/gstplayer/include/GenericPlayerContext.h	Stores flush controller as shared_ptr instead of value member.
media/server/gstplayer/source/tasks/generic/Flush.cpp	Removes postponing logic; waits via controller and marks async flush.
media/server/gstplayer/include/tasks/IGenericPlayerTaskFactory.h	Extends createFlush() signature with isAsync.
media/server/gstplayer/include/tasks/generic/GenericPlayerTaskFactory.h	Updates factory interface (remove RemoveSource, extend Flush).
media/server/gstplayer/source/tasks/generic/GenericPlayerTaskFactory.cpp	Removes RemoveSource creation; adds isAsync into Flush creation.
media/server/gstplayer/include/tasks/generic/Flush.h	Adds isAsync to task state.
media/server/gstplayer/source/tasks/generic/UpdatePlaybackGroup.cpp	Optionally links typefind to parser when requested.
media/server/gstplayer/source/tasks/generic/DeepElementAdded.cpp	Uses Utils type checks; tracks playsink bin and audio elements more robustly.
media/server/gstplayer/source/tasks/generic/NeedData.cpp	Removes “audioSourceRemoved” suppression.
media/server/gstplayer/source/tasks/generic/HandleBusMessage.cpp	Removes flush controller state updates (moved to dispatcher thread).
media/server/gstplayer/source/tasks/generic/CheckAudioUnderflow.cpp	Underflow no longer depends on audioSourceRemoved flag.
media/server/gstplayer/source/tasks/generic/AttachSource.cpp	Always reattaches audio via reattach path; removes playbin-flag toggling/needdata forcing.
media/server/gstplayer/source/Utils.cpp	Adds isAudioParser() helper.
media/server/gstplayer/include/Utils.h	Declares isAudioParser().
media/server/gstplayer/include/IGstGenericPlayerPrivate.h	Changes changePipelineState() to return GstStateChangeReturn; removes postponed flush/playbin flags API.
media/server/gstplayer/interface/IGstGenericPlayer.h	Changes play() to play(bool &async); removes removeSource() API.
media/server/gstplayer/include/GstGenericPlayer.h	Implements new play/flush/state-change patterns; adds large audio codec switch helpers + ongoing state-change counter.
media/server/gstplayer/source/GstGenericPlayer.cpp	Adds play async reporting, flush changes, and large on-the-fly audio codec switching logic.
media/server/gstplayer/source/GstWebAudioPlayer.cpp	Updates dispatcher thread factory call signature (adds flush controller arg).
media/server/gstplayer/source/GstTextTrackSink.cpp	Hardcodes subtitle display name instead of using WAYLAND_DISPLAY env var.
media/server/gstplayer/CMakeLists.txt	Removes RemoveSource task compilation unit.
media/server/gstplayer/source/tasks/generic/RemoveSource.cpp	Removes RemoveSource task implementation.
media/server/gstplayer/include/tasks/generic/RemoveSource.h	Removes RemoveSource task header.
tests/common/externalLibraryMocks/GstWrapperMock.h	Adds mocks for new IGstWrapper methods.
tests/unittests/media/server/gstplayer/dispatcherThread/GstDispatcherThreadTest.cpp	Updates dispatcher thread tests for flush controller integration + adds new state-change tests.
tests/unittests/media/server/gstplayer/genericPlayer/FlushOnPrerollControllerTest.cpp	Replaces postpone-flush tests with wait-based tests (includes a typo).
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/UpdatePlaybackGroupTest.cpp	Adds coverage for linking typefind with parser.
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/NeedDataTest.cpp	Removes test tied to audioSourceRemoved behavior.
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/FlushTest.cpp	Removes postpone-flush test.
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/RemoveSourceTest.cpp	Removes RemoveSource task tests.
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/GenericPlayerTaskFactoryTest.cpp	Removes RemoveSource factory test; updates Flush signature usage.
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/HandleBusMessageTest.cpp	Removes expectation for executePostponedFlushes().
tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/AttachSourceTest.cpp	Updates audio source reattach/switch expectations.
tests/unittests/media/server/gstplayer/genericPlayer/common/GenericTasksTestsBase.h	Removes RemoveSource helpers; adds typefind/parser link helpers.
tests/unittests/media/server/gstplayer/genericPlayer/common/GenericTasksTestsBase.cpp	Updates helpers for new flush/controller behavior and type checks.
tests/unittests/media/server/gstplayer/genericPlayer/common/GstGenericPlayerTestCommon.cpp	Updates dispatcher thread factory call signature.
tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerTest.cpp	Updates play tests to validate async out param and flush factory call signature.
tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerPrivateTest.cpp	Adds extensive tests for codec-switch paths and updated getSink behavior.
tests/unittests/media/server/gstplayer/mocks/gstplayer/GstDispatcherThreadFactoryMock.h	Updates mock signature with flush controller arg.
tests/unittests/media/server/gstplayer/mocks/gstplayer/FlushOnPrerollControllerMock.h	Updates mock interface to new controller methods.
tests/unittests/media/server/gstplayer/mocks/gstplayer/GstGenericPlayerMock.h	Updates play mock signature; removes removeSource mock.
tests/unittests/media/server/gstplayer/mocks/gstplayer/GstGenericPlayerPrivateMock.h	Updates changePipelineState return type; removes obsolete methods.
tests/unittests/media/server/gstplayer/mocks/gstplayer/GenericPlayerTaskFactoryMock.h	Updates Flush signature; removes RemoveSource mock.
tests/unittests/media/server/gstplayer/CMakeLists.txt	Drops RemoveSource test file from build.
tests/unittests/media/server/main/mediaPipeline/MiscellaneousFunctionsTest.cpp	Updates play path to priority task + async out param.
tests/unittests/media/server/main/mediaPipeline/base/MediaPipelineTestBase.h	Adds priority enqueue helper.
tests/unittests/media/server/main/mediaPipeline/base/MediaPipelineTestBase.cpp	Implements priority enqueue helper for tests.
tests/unittests/media/server/service/mediaPipelineService/MediaPipelineServiceTestsFixture.cpp	Updates play signature in fixture and expectations.
tests/unittests/media/server/mocks/service/MediaPipelineServiceMock.h	Updates play mock signature.
tests/unittests/media/server/mocks/main/MediaPipelineServerInternalMock.h	Updates play mock signature.
tests/unittests/media/server/ipc/mediaPipelineModuleService/MediaPipelineModuleServiceTestsFixture.cpp	Updates play expectations to include async out param.
tests/unittests/media/server/gstplayer/webAudioPlayer/CreateTest.cpp	Updates dispatcher thread factory mock invocation signature.
tests/unittests/media/server/gstplayer/webAudioPlayer/common/GstWebAudioPlayerTestCommon.cpp	Updates dispatcher thread factory expectation signature.
tests/unittests/media/client/mocks/ipc/MediaPipelineIpcMock.h	Updates play mock signature.
tests/unittests/media/client/mocks/main/MediaPipelineAndControlClientMock.h	Updates play mock signature.
tests/unittests/media/client/main/mediaPipeline/PlayPauseTest.cpp	Updates play tests to pass async out param.
tests/unittests/media/client/main/mediaPipeline/MediaPipelineProxyTest.cpp	Updates play passthrough test to pass async out param.
tests/unittests/media/client/ipc/mediaPipelineIpc/PlayPauseTest.cpp	Updates IPC play tests to pass async out param.
tests/componenttests/server/common/ExpectMessage.h	Increases default message timeout from 400ms to 600ms.
tests/componenttests/server/fixtures/MediaPipelineTest.h	Removes willRemoveAudioSource/willSetAudioAndVideoFlags helpers.
tests/componenttests/server/fixtures/MediaPipelineTest.cpp	Removes audio-source removal flush+flag logic; removeSource no longer waits worker.
tests/componenttests/server/tests/CMakeLists.txt	Replaces RemoveAudioPlaybackTest with SwitchAudioPlaybackTest.
tests/componenttests/server/tests/mediaPipeline/SwitchAudioPlaybackTest.cpp	Adds (disabled) component test for switching audio source mid-playback.
tests/componenttests/server/tests/mediaPipeline/AudioSourceSwitchTest.cpp	Updates to fetch audio-sink element and adds amlhalasink prefix handling in expectations.
tests/componenttests/server/tests/mediaPipeline/*.cpp (multiple)	Removes willRemoveAudioSource expectation calls across many pipeline tests.
tests/componenttests/client/tests/base/MediaPipelineTestMethods.cpp	Updates play helper to pass async out param.
media/client/ipc/source/MediaKeysIpc.cpp	Adds OUTPUT_RESTRICTED to toString(); minor formatting changes.
wrappers/include/GstWrapper.h / wrappers/interface/IGstWrapper.h	Adds low-level GStreamer accessors needed by new codec-switch code.

Comments suppressed due to low confidence (1)

media/server/gstplayer/source/GstGenericPlayer.cpp:879

• Similar to firstTimeSwitchFromAC3toAAC(), gstPadGetPeer()/gstPadUnlink() are called with pad pointers that may be NULL (e.g., audioDecSrcPad/audioDecSinkPad/audioParseSrcPad/audioParseSinkPad). Please add null checks before calling these wrappers and before unref’ing pads/peers to avoid crashes when elements don’t expose the expected static pads.

    // Get AudioDecoder Src Pads
    if ((audioDecSrcPad = m_gstWrapper->gstElementGetStaticPad(m_context.playbackGroup.m_curAudioDecoder, "src")) !=
        NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioDecoder Src Pad = %p", audioDecSrcPad);
    // Get AudioDecoder Sink Pads
    if ((audioDecSinkPad = m_gstWrapper->gstElementGetStaticPad(m_context.playbackGroup.m_curAudioDecoder, "sink")) !=
        NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioDecoder Sink Pad = %p", audioDecSinkPad);
    // Get AudioDecoder Src Peer i.e. Downstream Element Pad
    if ((audioDecSrcPeerPad = m_gstWrapper->gstPadGetPeer(audioDecSrcPad)) != NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioDecoder Src Downstream Element Pad = %p", audioDecSrcPeerPad);
    // Get AudioDecoder Sink Peer i.e. Upstream Element Pad
    if ((audioDecSinkPeerPad = m_gstWrapper->gstPadGetPeer(audioDecSinkPad)) != NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioDecoder Sink Upstream Element Pad = %p", audioDecSinkPeerPad);
    // Get AudioParser Src Pads
    if ((audioParseSrcPad = m_gstWrapper->gstElementGetStaticPad(m_context.playbackGroup.m_curAudioParse, "src")) !=
        NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioParser Src Pad = %p", audioParseSrcPad);
    // Get AudioParser Sink Pads
    if ((audioParseSinkPad = m_gstWrapper->gstElementGetStaticPad(m_context.playbackGroup.m_curAudioParse, "sink")) !=
        NULL) // Unref the Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioParser Sink Pad = %p", audioParseSinkPad);
    // Get AudioParser Src Peer i.e. Downstream Element Pad
    if ((audioParseSrcPeerPad = m_gstWrapper->gstPadGetPeer(audioParseSrcPad)) != NULL) // Unref the Peer Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioParser Src Downstream Element Pad = %p", audioParseSrcPeerPad);
    // Get AudioParser Sink Peer i.e. Upstream Element Pad
    if ((audioParseSinkPeerPad = m_gstWrapper->gstPadGetPeer(audioParseSinkPad)) != NULL) // Unref the Peer Pad
        RIALTO_SERVER_LOG_DEBUG("OTF -> Current AudioParser Sink Upstream Element Pad = %p", audioParseSinkPeerPad);
    // AudioDecoder Downstream Unlink
    if (m_gstWrapper->gstPadUnlink(audioDecSrcPad, audioDecSrcPeerPad) == FALSE)
        RIALTO_SERVER_LOG_DEBUG("OTF -> AudioDecoder Downstream Unlink Failed");
    // AudioDecoder Upstream Unlink
    if (m_gstWrapper->gstPadUnlink(audioDecSinkPeerPad, audioDecSinkPad) == FALSE)
        RIALTO_SERVER_LOG_DEBUG("OTF -> AudioDecoder Upstream Unlink Failed");
    // AudioParser Downstream Unlink
    if (m_gstWrapper->gstPadUnlink(audioParseSrcPad, audioParseSrcPeerPad) == FALSE)
        RIALTO_SERVER_LOG_DEBUG("OTF -> AudioParser Downstream Unlink Failed");
    // AudioParser Upstream Unlink
    if (m_gstWrapper->gstPadUnlink(audioParseSinkPeerPad, audioParseSinkPad) == FALSE)
        RIALTO_SERVER_LOG_DEBUG("OTF -> AudioParser Upstream Unlink Failed");

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 118 out of 118 changed files in this pull request and generated 14 comments.

Comments suppressed due to low confidence (1)

tests/componenttests/server/tests/mediaPipeline/SwitchAudioPlaybackTest.cpp:224

• The new component test is checked in as DISABLED_SwitchAudio, so it won’t run in CI even though the file is added to the test target. If this scenario is important for the change, please enable the test (or add an active equivalent) or document why it must remain disabled to avoid losing coverage for audio switching.

[Copilot]

Pull request overview

Copilot reviewed 118 out of 118 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (3)

wrappers/source/OcdmSession.cpp:244

• These RIALTO_COMMON_LOG_ERROR("DEBUG PURPOSE ...") calls add noisy ERROR-level logging on every decrypt (and include embedded newlines). Also the else branches log "returning error" but do not return, which is misleading during troubleshooting. Please remove or downgrade to DEBUG/TRACE and only log real error paths; consider removing the misleading else logs or returning an actual error when intended.
  serverManager/common/source/HealthcheckService.cpp:158
• handleError() also uses m_failedPings[serverId], which will create a new entry if serverId was never registered via onPingSent() (e.g., if handleError is called for an untracked server). Consider guarding with find()/try_emplace() to make it explicit when a server becomes tracked and avoid silent insertion on error paths.
  tests/componenttests/server/tests/mediaPipeline/SwitchAudioPlaybackTest.cpp:3
• The file now starts with a blank line before the license header comment. If tooling expects the header at line 1 (common for license scanners), this may cause false negatives. Consider removing the leading blank line so the header begins at the top of the file.

[Copilot]

Pull request overview

Copilot reviewed 119 out of 119 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (2)

media/server/main/source/MediaKeysServerInternal.cpp:648

• decrypt() now performs a blocking sleep/retry loop on OUTPUT_RESTRICTED, potentially stalling the calling thread for up to the timeout duration. This can have significant playback/latency impact; consider making the retry non-blocking (e.g., schedule retries on the worker/main thread) or ensure the caller is explicitly designed to tolerate this delay.
  media/server/main/source/MediaKeysServerInternal.cpp:640
• There are extensive "DEBUG PURPOSE" logs emitted at ERROR level for every decrypt attempt/status, which will be very noisy and misleading in production. Please remove these or downgrade to DEBUG with concise messages (and ideally avoid per-buffer logs unless behind a feature flag).

[Copilot]

Pull request overview

Copilot reviewed 119 out of 119 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

media/client/ipc/source/MediaPipelineIpc.cpp:356

• MediaPipelineIpc::play(bool &async) returns false here without assigning async, so callers can observe an uninitialized/previous value. Please set async = false at the beginning of the method (and/or on each failure path).

{
    if (!reattachChannelIfRequired())
    {
        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
        return false;