Add phpunit 11 support #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pieterocp Just a thought: if you literally copy someone else's code .... you may want to give them credit... |
Credited to dmaicher Co-authored-by: dmaicher <[email protected]>
… this version works with most/all phpunit installations Credit to jrfnl for the suggestion and the phar test setup from Yoast Co-authored-by: jrfnl <[email protected]>
pieterocp
force-pushed
the
add-phpunit-11-support
branch
from
ec46deb to
6b1adb8
Compare
Apologies, added to the commit messages the folks who's work I glued together. So thank you @jrfnl and @dmaicher. |
|
@pieterocp Appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for phpunit version 11.* to be used, addressing #85 + should handle the case of https://github.com/rdohms/phpunit-arraysubset-asserts/pull/81/files#r1557304228 so thank you for the suggestion.
Did run the job using
nektos/actand outside of being ratelimited if I ran several at once, it seemed to generally work. The version constraints can probably be changed a bit though.Tested with inside a project, which has this composer installed, plus ran tests locally on using a phpunit.phar installation.