Skip to content

docs(basic) add bs5 examples for basic-ts, basic-react-router and basic-sass-custom-theming #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lcheunglci
Copy link
Contributor

I duplicated the basic-ts, basic-react-router and basic-sass-custom-theming examples into basic-ts-v5, basic-react-router-v5 and basic-sass-custom-theming-v5 and bumped the version of bootstrap from 4.6.0 to 5.1.3 and react-bootstrap from 1.5.2 to 2.0.0. I fixed the compiler error caused by the deprecated and replaced it with a with similar behaviour and updated the README so it includes the new v5 examples.

@kyletsang kyletsang merged commit f8a1a91 into react-bootstrap:master Nov 11, 2021
@lcheunglci lcheunglci deleted the docs-add-bs5-additional-basic-examples branch November 11, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants