Skip to content

make AppName warning better #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
pvinis opened this issue Dec 30, 2019 · 3 comments
Closed
5 tasks done

make AppName warning better #113

pvinis opened this issue Dec 30, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pvinis
Copy link
Member

pvinis commented Dec 30, 2019 •
edited by lucasbento
Loading

Description

After #112, @lucasbento suggested some good changes:

  • Have it appear only after the diff has been rendered
  • Move it to be shown below the "Useful content" section
  • Have the same width as the useful content section to maintain consistency
  • Use "info" alert instead of "warning"
  • Add a comment on it that the app name can be changed in the settings (this would happen in Feature: replace RnDiffApp with entered AppName #111 probably)

@Naturalclar, since you have worked on both of these, we would be very happy if you wanted to pick these ones up too 🙌
@pvinis pvinis added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 30, 2019
@lucasbento
Copy link
Member

Just added a couple more points, @Naturalclar let us know what you think 🙂

@Naturalclar
Copy link
Member

These points all sounds good! I can pick these up 👍

@Naturalclar Naturalclar mentioned this issue Dec 31, 2019
Merged
1 task
@lucasbento
Copy link
Member

Done by @Naturalclar on #130 🙂

@Naturalclar Naturalclar mentioned this issue Jan 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvinis @lucasbento @Naturalclar