Add text to AppNameWarning about setting AppName #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbento
reviewed
Jan 9, 2020
| @@ -15,6 +15,8 @@ export const AppNameWarning = () => ( | |||
| <Markdown> | |||
| Keep in mind that `RnDiffApp` and `rndiffapp` are placeholders. When | |||
| upgrading, you should replace them with your actual project's name. | |||
| You can also make these replacements by setting your app name from the | |||
There was a problem hiding this comment.
How about:
You can also provide your app name by clicking the settings icon on the top right.?
There was a problem hiding this comment.
Sure, nice and concise :)
…lclar/upgrade-helper into chore/AddTextToAppWarning
lucasbento
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finishing up #113 by adding information about being able to change the AppName from the settings.
Test Plan
What are the steps to reproduce?
Checklist