-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Document formSheet props and limitiations #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document formSheet props and limitiations #1402
Conversation
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay,
we still need to record the examples. I'll read through text once we got this ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
Co-authored-by: Kacper Kafara <[email protected]>
Co-authored-by: Kacper Kafara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are a lot of assets, but we should be fine.
However before merging we need to improve PR description.
PR description updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
One thing I'd like to see for bottom sheet is a fully runnable example on snack so devs can test it out directly. You can copy one of the other examples on this page and tweak it to add bottom sheet.
Description
Added details about formSheet - props, examples.
Changes
presentation: 'formSheet'
description to specify correct behavior on Android,presentation: 'formSheet'
to showcase different detents and include both Android and iOS,formSheet
on Android,formSheet
: