Skip to content

Document formSheet props and limitiations #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kligarski
Copy link
Contributor

@kligarski kligarski commented Feb 20, 2025

Description

Added details about formSheet - props, examples.

Changes

  • updated presentation: 'formSheet' description to specify correct behavior on Android,
  • changed video for presentation: 'formSheet' to showcase different detents and include both Android and iOS,
  • added information about current limitation of formSheet on Android,
  • described props for formSheet:
    • added descriptions with supported values,
    • added simple videos showcasing the prop.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit c81837e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/67cafda3665d180008fefb5f
😎 Deploy Preview https://deploy-preview-1402--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kligarski
Copy link
Contributor Author

@kkafar

Copy link
Contributor

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay,

we still need to record the examples. I'll read through text once we got this ready.

@kkafar kkafar self-requested a review February 20, 2025 11:24
@kligarski kligarski marked this pull request as ready for review February 24, 2025 10:14
Copy link
Contributor

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

kligarski and others added 2 commits February 25, 2025 12:35
Co-authored-by: Kacper Kafara <[email protected]>
Co-authored-by: Kacper Kafara <[email protected]>
Copy link
Contributor

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are a lot of assets, but we should be fine.

However before merging we need to improve PR description.

@kligarski
Copy link
Contributor Author

PR description updated.

@kkafar kkafar requested a review from satya164 February 25, 2025 15:15
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

One thing I'd like to see for bottom sheet is a fully runnable example on snack so devs can test it out directly. You can copy one of the other examples on this page and tweak it to add bottom sheet.

@kligarski kligarski requested a review from kkafar March 7, 2025 14:08
@satya164 satya164 merged commit 191765f into react-navigation:main Mar 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants