Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-BC for TCK: Corrects a typo in test method from *Compuatation to … #306

Merged
merged 1 commit into from
May 22, 2017

Conversation

viktorklang
Copy link
Contributor

…*Computation

Fixes #304

@reactive-streams/contributors What do we think, is it OK to do non-BC updates to the TCK for a minor/patch version?

@viktorklang
Copy link
Contributor Author

@reactive-streams/contributors Ping

@viktorklang
Copy link
Contributor Author

@reactive-streams/contributors Is it fine to do a binary incompatible change in the TCK?

@ktoso
Copy link
Contributor

ktoso commented Apr 28, 2017

I think we can make such changes. Users are library implementors, and upgrading the TCK may indeed require changing things anyway (e.g. your Publisher now fails etc), so it's not really meant to be a "upgrade and do nothing" upgrade scenario.

I do think however that we should provide a migration guide as we merge such incompatible changes. A simple migration-guide.md would work, that just lists "method name changed from ..." etc. Please include such file stub along with this PR?

The other PR with the thrown Exception type is another one of this kind that we should then add to the markdown file.

@viktorklang viktorklang force-pushed the wip-compuatation-fix-√ branch from fb3472b to 01341b9 Compare April 30, 2017 20:48
@viktorklang
Copy link
Contributor Author

viktorklang commented May 22, 2017

@reactive-streams/contributors Since no one objects to this breaking change (method rename) in the TCK I'll merge this. Since the TCK needs to be re-run and this typically happens on tests anyway, bumping the RS version means having to change the build anyway, s o it may as well also be renaming a couple of methods?

@viktorklang viktorklang merged commit 2879ce0 into master May 22, 2017
@viktorklang viktorklang deleted the wip-compuatation-fix-√ branch May 22, 2017 07:48
@viktorklang viktorklang added this to the 1.0.1 milestone Jun 26, 2017
@ktoso ktoso mentioned this pull request Jun 26, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants