Prepare 1.0.1 #379

viktorklang · 2017-06-19T12:55:23Z

WIP

Ship 1.0.1-RC1
Update RELEASE-NOTES.md
Write release announcement

ktoso

Looking forward to it :)
Another thing that would be very useful to maintain here for the 1.0.1 would be a milestone to which we'd assign issues that we resolved in that version

viktorklang · 2017-06-22T07:59:49Z

@ktoso You mean like https://github.com/reactive-streams/reactive-streams-jvm/milestone/10 ?

ktoso · 2017-06-22T13:48:56Z

Yeah, that's how I meant, I missed that milestones got assigned to most, thanks :)

viktorklang · 2017-06-22T13:52:47Z

@ktoso Yeah, and I've just pushed a draft of release notes. Would you be able to summarize the improvements to the TCK?

viktorklang · 2017-06-26T09:58:06Z

RELEASE-NOTES.md

+  + No changes
+  + Improved Javadoc
+- TCK


@akarnokd @ktoso Could you please take a stab at listing the improvements to the TCK? Thank you!
(It's fine to add it as comments here and I'll incorporate it into the release notes.)

/cc @reactive-streams/contributors

Fixed potential resource leaks in partially consuming Publisher tests

Improved Publisher test descriptions via JavaDoc

Fixed potential resource leaks in partially emitting Subscriber tests

Improved Subscriber test descriptions via JavaDoc

ktoso

Looking good, proposed some additions and links. Links to those PRs I think are helpful in case someone will have trouble updating, they could see what changed easier then

ktoso · 2017-06-26T18:27:47Z

RELEASE-NOTES.md

+  + Improved JavaDoc
+  + Multiple test [alterations](#tck-alterations)
+- New contributors since 1.0.0


weird style to be honest, usually one lists contributors who contributed to a given milestone/release, not only the new ones?

Yeah, you're right, I'll list all, and then annotate the new ones :)

ktoso · 2017-06-26T18:31:36Z

RELEASE-NOTES.md

+- Fixed potential resource leaks in partially consuming Publisher tests
+- Fixed potential resource leaks in partially emitting Subscriber tests
+- Renamed `untested_spec305_cancelMustNotSynchronouslyPerformHeavyCompuatation` to `untested_spec305_cancelMustNotSynchronouslyPerformHeavyComputation` (typo)


Link to #306

ktoso · 2017-06-26T18:33:09Z

RELEASE-NOTES.md

+---
+
+## TCK alterations


Add:

Allow configuring separate timeout for "no events during N time", allowing for more aggressive timeouts in the rest of the test suite if required +tck #308 allow configuring "no events during N time" separately #314

New test verifying Rule 2.10, in which subscriber must be prepared to receive onError signal without having signaled request before +tck #362 wait for request signal in 209, and new additional tests #374

those are more interesting than the remaining "just a fix" ones :)

ktoso · 2017-06-26T18:38:47Z

RELEASE-NOTES.md

+
+- Fixed potential resource leaks in partially consuming Publisher tests
+- Fixed potential resource leaks in partially emitting Subscriber tests


Link to #372 and #373

ktoso · 2017-06-26T18:40:25Z

RELEASE-NOTES.md

+## TCK alterations
+
+- Fixed potential resource leaks in partially consuming Publisher tests


Link to #375

ktoso · 2017-06-27T00:17:53Z

RELEASE-NOTES.md

+- Fixed potential resource leaks in partially consuming Publisher tests (#375)
+- Fixed potential resource leaks in partially emitting Subscriber tests (#372, #373)
+- Renamed `untested_spec305_cancelMustNotSynchronouslyPerformHeavyCompuatation` to `untested_spec305_cancelMustNotSynchronouslyPerformHeavyComputation` (#306)


Have the issue numbers be links?

viktorklang · 2017-06-27T09:25:40Z

@reactive-streams/contributors Please review this PR, I think we're ready to ship 1.0.1-RC1 (and have the implementations make sure that the new TCK doesn't cause any havoc).

DougLea · 2017-06-27T10:48:23Z

looks good to me

viktorklang · 2017-06-28T14:54:10Z

@reactive-streams/contributors @rkuhn @smaldini Who wants to do the honors of publishing the RC1?

viktorklang · 2017-06-29T09:12:57Z

@reactive-streams/contributors Merging this into master and tagging. Publish will happen as soon as we have someone who wants to do the honors :)

rkuhn · 2017-06-29T09:18:59Z

I can probably do it later today, need to finish some other stuff first, though.

viktorklang · 2017-06-29T09:21:16Z

@rkuhn That'd be much welcome. Let me know if you want to coordinate. I'm merging this to master and tagging it.

viktorklang · 2017-06-29T09:22:43Z

@rkuhn merged and tagged

ktoso · 2017-06-29T09:26:49Z

Yay, thanks Roland. Ping if you'll want a sanity check of the artifact

rkuhn · 2017-06-29T11:39:52Z

Manually applying aaac86e I have signed and uploaded to https://oss.sonatype.org/content/repositories/orgreactivestreams-1030, please let me know if everything arrived okay.

viktorklang · 2017-06-29T11:49:05Z

@rkuhn LGTM!

akarnokd · 2017-06-29T12:01:07Z

RxJava 2.1.2 snapshot passes this TCK locally (107 classes).

ktoso · 2017-06-29T12:44:03Z

Akka Streams 2.5.3 all green: Passed: Total 534, Failed 0, Errors 0, Passed 534, Ignored 424 🎉

Artifacts look good as well.

viktorklang · 2017-06-29T12:45:10Z

?

rkuhn · 2017-06-29T12:49:59Z

Shipped it :-)

viktorklang · 2017-06-29T12:52:18Z

Thanks @rkuhn, @ktoso, and all the @reactive-streams/contributors!

Now we'll give people a week or two to verify that the TCK works as expected and then ship the final version.

viktorklang · 2017-06-29T12:55:44Z

@rkuhn I'ev also pushed the correct tag now: https://github.com/reactive-streams/reactive-streams-jvm/tree/v1.0.1-RC1

viktorklang added this to the 1.0.1 milestone Jun 19, 2017

viktorklang force-pushed the 1.0.1-prep branch from 1bdd8c9 to c3b2c6d Compare June 19, 2017 12:58

ktoso approved these changes Jun 21, 2017

View reviewed changes

viktorklang force-pushed the 1.0.1-prep branch 2 times, most recently from 11b3358 to f7458b9 Compare June 26, 2017 09:56

viktorklang commented Jun 26, 2017

View reviewed changes

viktorklang force-pushed the 1.0.1-prep branch 6 times, most recently from 5416e83 to ff7f251 Compare June 26, 2017 11:16

viktorklang mentioned this pull request Jun 26, 2017

+tck #284 support "demand when all downstreams demand" Processor in TCK #287

Closed

ktoso reviewed Jun 26, 2017

View reviewed changes

ktoso approved these changes Jun 26, 2017

View reviewed changes

viktorklang force-pushed the 1.0.1-prep branch from ff7f251 to c6b7c10 Compare June 26, 2017 20:44

ktoso reviewed Jun 27, 2017

View reviewed changes

viktorklang force-pushed the 1.0.1-prep branch 4 times, most recently from 40a44ad to 17cb353 Compare June 27, 2017 09:19

akarnokd approved these changes Jun 27, 2017

View reviewed changes

viktorklang force-pushed the 1.0.1-prep branch from 17cb353 to 9b637bb Compare June 28, 2017 10:10

Version 1.0.1

ec44e03

viktorklang force-pushed the 1.0.1-prep branch from 9b637bb to ec44e03 Compare June 29, 2017 09:14

viktorklang merged commit 11469fa into master Jun 29, 2017

ktoso mentioned this pull request Jun 29, 2017

Create RELEASE-NOTES for 1.0.1 #363

Closed

viktorklang deleted the 1.0.1-prep branch November 15, 2017 15:16


		- Fixed potential resource leaks in partially consuming Publisher tests
		- Fixed potential resource leaks in partially emitting Subscriber tests

		## TCK alterations

		- Fixed potential resource leaks in partially consuming Publisher tests

Prepare 1.0.1 #379

Prepare 1.0.1 #379

Conversation

viktorklang commented Jun 19, 2017 • edited Loading

ktoso left a comment

Choose a reason for hiding this comment

viktorklang commented Jun 22, 2017 • edited Loading

ktoso commented Jun 22, 2017

viktorklang commented Jun 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ktoso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viktorklang commented Jun 27, 2017

DougLea commented Jun 27, 2017

viktorklang commented Jun 28, 2017

viktorklang commented Jun 29, 2017

rkuhn commented Jun 29, 2017

viktorklang commented Jun 29, 2017

viktorklang commented Jun 29, 2017

ktoso commented Jun 29, 2017

rkuhn commented Jun 29, 2017

viktorklang commented Jun 29, 2017

akarnokd commented Jun 29, 2017 • edited Loading

ktoso commented Jun 29, 2017 • edited Loading

viktorklang commented Jun 29, 2017

rkuhn commented Jun 29, 2017

viktorklang commented Jun 29, 2017

viktorklang commented Jun 29, 2017

viktorklang commented Jun 19, 2017 •

edited

Loading

viktorklang commented Jun 22, 2017 •

edited

Loading

akarnokd commented Jun 29, 2017 •

edited

Loading

ktoso commented Jun 29, 2017 •

edited

Loading