TCK: Fail early if registerOnSubscribe is not called #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorklang
reviewed
Dec 4, 2017
| @@ -539,6 +539,7 @@ public WhiteboxTestStage(TestEnvironment env, boolean runDefaultInit) throws Int | |||
| probe = new WhiteboxSubscriberProbe<T>(env, subscriber); | |||
| subscribe(createSubscriber(probe)); | |||
| probe.puppet.expectCompletion(env.defaultTimeoutMillis(), String.format("Subscriber %s did not `registerOnSubscribe`", sub())); | |||
| env.verifyNoAsyncErrorsNoDelay(); | |||
There was a problem hiding this comment.
Nicely done, @akarnokd! 👍
viktorklang
approved these changes
Dec 4, 2017
ktoso
approved these changes
Dec 5, 2017
Closed
|
@reactive-streams/contributors Alright, merging this TCK change as it doesn't impact any RS semantics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure the TCK checks if the
WhiteboxSubscriberProbe.registerOnSubscribe()was called before any test body tries to use the (unavailable) puppet, crashing withNullPointerExceptionand hiding the fact the method call was missing.Fixes: #416