Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.Router has a flaky test #472

Closed
Daniel15 opened this issue Nov 11, 2017 · 2 comments
Closed

React.Router has a flaky test #472

Daniel15 opened this issue Nov 11, 2017 · 2 comments

Comments

@Daniel15
Copy link
Member

The build seems to randomly fail on React.Tests.Router.HtmlHelperExtensionsTest.ShouldRunCustomContextHandler:

[xUnit.net 00:00:00.2936128]   Discovering: React.Tests
  [xUnit.net 00:00:00.7217786]   Discovered:  React.Tests
  [xUnit.net 00:00:00.9747520]   Starting:    React.Tests
  [xUnit.net 00:00:02.4140782]     React.Tests.Router.HtmlHelperExtensionsTest.ShouldRunCustomContextHandler [FAIL]
  [xUnit.net 00:00:02.4150445]       System.NullReferenceException : Object reference not set to an instance of an object.
  [xUnit.net 00:00:02.4157439]       Stack Trace:
  [xUnit.net 00:00:02.4172806]            at React.Router.HtmlHelperExtensions.ReactRouterWithContext[T](HtmlHelper htmlHelper, String componentName, T props, String path, String htmlTag, String containerId, Boolean clientOnly, Boolean serverOnly, String containerClass, Action`2 contextHandler)
  [xUnit.net 00:00:02.4174844]         Router\HtmlHelperExtensionsTest.cs(204,0): at React.Tests.Router.HtmlHelperExtensionsTest.ShouldRunCustomContextHandler()
  [xUnit.net 00:00:02.4358859]   Finished:    React.Tests
  Failed   React.Tests.Router.HtmlHelperExtensionsTest.ShouldRunCustomContextHandler
EXEC : error Message:  [C:\projects\react-net\build.proj]
   System.NullReferenceException : Object reference not set to an instance of an object.
  Test Run Failed.
  Stack Trace:
     at React.Router.HtmlHelperExtensions.ReactRouterWithContext[T](HtmlHelper htmlHelper, String componentName, T props, String path, String htmlTag, String containerId, Boolean clientOnly, Boolean serverOnly, String containerClass, Action`2 contextHandler)
     at React.Tests.Router.HtmlHelperExtensionsTest.ShouldRunCustomContextHandler()

cc @gunnim

@gunnim
Copy link
Contributor

gunnim commented Nov 15, 2017

#475 seems to take care of the issue, i'm no longer able to reproduce the bug 👍

@Daniel15
Copy link
Member Author

Thank you for fixing it, @dustinsoftware :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants