Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xUnit tests in VS2017 #474

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

dustinsoftware
Copy link
Member

Due to an xUnit bug, tests would attempt to run, but then fail
immediately. Updating the packages fixes the issue.

microsoft/vstest#811

Due to an xUnit bug, tests would attempt to run, but then fail
immediately. Updating the packages fixes the issue.

microsoft/vstest#811
@Daniel15
Copy link
Member

I was hoping this would fix #472, but it still seems flaky (based on the AppVeyor failure). React.Tests.Router.HtmlHelperExtensionsTest fails sporadically. :(

@Daniel15 Daniel15 merged commit 4413448 into reactjs:master Nov 13, 2017
@dustinsoftware
Copy link
Member Author

I found the fix and will open another PR in just a minute..... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants