Skip to content

FIX: VroomJS engine initialize failed on macOS. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

FIX: VroomJS engine initialize failed on macOS. #362

wants to merge 1 commit into from

Conversation

holmesconan
Copy link

#338 mentioned this error, and as the chakra js engine already added, which support osx-x64 platform, I think the simplest way is to skip the VroomJS engine if it is not available. And the fix is also a defensive programming for this situation.

@Daniel15
Copy link
Member

Daniel15 commented Jan 5, 2017

People still using .NET Framework 4.0 or 4.5 on Linux (via Mono) still need to see the VroomJs initialisation error, though.

Instead of doing it this way, you can modify your app to only add the Chakra engine rather than VroomJs. Just configure the engines before calling UseReact:

var engineSwitcher = JsEngineSwitcher.Instance;
engineSwitcher.EngineFactories
    .AddChakraCore();

app.UseReact(config =>

@dustinsoftware
Copy link
Member

Thanks for the PR. Unfortunately this isn't mergeable as-is and hasn't had any recent activity, so I'm going to close this for now. Please feel free to re-open when you'd like to revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants