Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Community, Enterprise, or Professional VS 2017 versions #457

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Allowed Community, Enterprise, or Professional VS 2017 versions #457

merged 1 commit into from
Nov 4, 2017

Conversation

JoshuaKGoldberg
Copy link
Contributor

Loops over the potential MSBuild.exe paths for all three, and runs with the first one. If one isn't found it complains.

Fixes #452.

Loops over the potential MSBuild.exe paths for all three, and runs with the first one. If one isn't found it complaints.
@Daniel15
Copy link
Member

Daniel15 commented Nov 4, 2017

Thanks! I wish there was an environment variable for the path to MSBuild

@Daniel15 Daniel15 merged commit afac9d6 into reactjs:master Nov 4, 2017
@JoshuaKGoldberg JoshuaKGoldberg deleted the dev-build-bat-vs-versions branch November 5, 2017 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants