Add .NETCore 3 preview support #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Daniel15
reviewed
May 3, 2019
| @@ -16,13 +20,13 @@ namespace React.AspNet | |||
| /// </summary> | |||
| public class AspNetFileSystem : FileSystemBase | |||
| { | |||
| private readonly IHostingEnvironment _hostingEnv; | |||
| private readonly IWebHostEnvironment _hostingEnv; | |||
|
|
|||
| /// <summary> | |||
| /// Initializes a new instance of the <see cref="AspNetFileSystem"/> class. | |||
| /// </summary> | |||
| /// <param name="hostingEnv">The ASP.NET 5 hosting environment</param> | |||
There was a problem hiding this comment.
Hah, this still says "ASP.NET 5". We should change that 😛
Daniel15
reviewed
May 3, 2019
Daniel15
reviewed
May 3, 2019
|
My plan was to ship an alpha targeting the .NET Core 3 preview alongside netstandard, and when .NET Core 3 ships we can remove the alpha flag. |
|
Blocked by dotnet/sdk#3146 |
|
For whatever reason, I can't get CI to work. This is published as 5.0.0-alpha3. @mbaumanndev |
This was referenced May 11, 2019
1 task
Azure pipelines works better and faster with .NET Core
|
@dustinsoftware Since you deleted the AppVeyor build, the dev build NuGet server (https://reactjs.net/getting-started/download.html#development-builds) won't work any more, as that was coming from AppVeyor. Potentially we can use GitHub's package hosting once that's available. In the interim I can probably set up a self-hosted package server again. |
|
Sorry about that.. TIL we have a custom NuGet dev build channel.
I wonder if we can set up Azure Pipelines to publish to a custom NuGet
feed? (I hope so)
I am currently just publishing alpha NuGet builds to the main feed so that
people don’t have to use a new package source to try out alpha features...
…On Tue, Jun 4, 2019 at 01:11, Daniel Lo Nigro ***@***.***> wrote:
@dustinsoftware <https://github.com/dustinsoftware> Since you deleted the
AppVeyor build, the dev build NuGet server (
https://reactjs.net/getting-started/download.html#development-builds)
won't work any more, as that was coming from AppVeyor. Potentially we can
use GitHub's package hosting once that's available. In the interim I can
probably set up a self-hosted package server again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#791?email_source=notifications&email_token=AAHGCFXL65MC2DRIFPGIIIDPYX2RZA5CNFSM4HJHVKZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3N4VA#issuecomment-498523732>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHGCFUG5FIMEXCVLCX7BILPYX2RZANCNFSM4HJHVKZQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP 🚨