Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated HomeContent.js to German language. #387

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

timowenz
Copy link

@timowenz timowenz commented Jul 18, 2024

HomeContent.js is now updated for German language. If you have suggestions for improvement, please let me know.

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
de-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2025 1:18pm

ph1p
ph1p previously requested changes Feb 4, 2025
Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've some suggestions

timowenz and others added 3 commits March 9, 2025 14:17
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
@ChrisB9 ChrisB9 dismissed ph1p’s stale review March 11, 2025 05:58

Everything has been resolved :)

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 128.38 KB (🟡 +559 B) 238.78 KB
/500 128.39 KB (🟡 +559 B) 238.79 KB
/[[...markdownPath]] 130.26 KB (🟡 +559 B) 240.66 KB
/errors 128.66 KB (🟡 +559 B) 239.06 KB
/errors/[errorCode] 128.64 KB (🟡 +559 B) 239.04 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@ChrisB9
Copy link
Collaborator

ChrisB9 commented Mar 11, 2025

It looks good enough!
After reading it again, I do believe "Mache Full-Stack mit einem Framework" and "Starte mit einem Framework" sound like very english-style german, but it is acceptable and the PR has been waiting for approval way too long!

My suggestion for the two markers I had, may be something like "Werde Full-Stack mit einem Framework" and "Beginne mit einem Framework", but it still doesn't sound good enough to my liking to add it as suggestion - hence I'll leave it as is and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants