-
-
Notifications
You must be signed in to change notification settings - Fork 458
PR merge rule and PR template suggestion #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
if this checklist included in template, I think this will be able to help contributors to check their tranlation progress. |
I agree :)
Good idea. We need to add |
Yeah, It is a very coool idea. |
I think the third item should be "맞춤법 검사" rather than "띄어쓰기 검사", as the online tool checks more than spacing. |
The idea of |
I applied "Require pull request reviews before merging" with options in the screenshot. |
I agree 👍 |
I will close this issue and make PR for PR templete this sunday. if there is any feed back on the checklist, comment on this thread by this week. |
The current PR template, which introduced by #25, contains broken links. If we don't have appropriate references for the items yet, it would be better to remove the links. |
pr merge
Since no PR has been merged yet, I think it would be good to make rule for merging PR.
pr template
here is the current PR template, but if the checklist is included here, contributors and reviewers can check the progress of the PR so it can bring better communicate better.
The text was updated successfully, but these errors were encountered: