Update Pull Request Templates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taehwanno
reviewed
Feb 14, 2019
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| [ ] glossary 용어 확인 (wiki or issue links) | ||
| [ ] 띄어쓰기 검사 (http://speller.cs.pusan.ac.kr/) | ||
| [ ] 리뷰 반영 | ||
| [ ] 최종 PR |
There was a problem hiding this comment.
PR description로 활용되니 마크다운 문법과 문장이 수정이 필요해요.
공통 스타일 가이드 및 용어 확인은 master에 반영될 때 마크다운 링크로 대체하고 그 전에는 issue 링크를 주도록 해요 :)
## 진행 상황
- [ ] 번역 초안 작성
- [ ] [공통 스타일 가이드 확인](link)
- [ ] [용어 확인](link)
- [ ] [맞춤법 검사](http://speller.cs.pusan.ac.kr/)
- [ ] 리뷰 반영
- [ ] 최종 PR
아래는 수정된 마크다운 렌더링 결과입니다.
진행 상황
- 번역 초안 작성
- 공통 스타일 가이드 확인
- 용어 확인
- 맞춤법 검사
- 리뷰 반영
- 최종 PR
There was a problem hiding this comment.
@taehwanno
I checked:D, I deleted the final PR part because I thought it could be replaced by the reviewers' approve. I think there are foreigners, so I mixed English writing.
확인했습니다 :D, 최종 PR부분은 reviewer들의 approve로 대체해도 될것같아서 삭제했습니다. 외국인분들도 있으신것같으니 영어표기도 혼용했습니다.
|
기본적인 부분 반영했습니다. 추후 수정부탁드립니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a PR for the part you suggested. Please let me know if you have an opinion.(#23)