Annotate with comments #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| memoizationCache.get(child.key) | ||
| // When the UI changes, it usually happens just in some parts of the screen. | ||
| // This means that most children with the same keys will likely render to the same output. | ||
| // We give each child each own memoization map, so that in the common case its output can be memoized. |
There was a problem hiding this comment.
I think you meant "We give each child its own ..."
|
Thanks @sebmarkbage and @gaearon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit hard for me to read because of all the existing preconceptions about how React works.
As I read through this, I tried to annotate it with comments to help me (and maybe other people) understand what’s really going on here. Partial application with
bind()makes it especially confusing due to “invisible” arguments you have to keep a track of.Not sure if you’d like to take this but I gave it a try.