[fixed] ModalPortal's componentWillReceiveProps #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this fixes #11 for me and does not seem to break anything. Could we get this merged? |
ryanflorence
added a commit
that referenced
this pull request
Feb 26, 2015
[fixed] ModalPortal's componentWillReceiveProps
|
v0.1.0 published with this fix |
|
@ryanflorence Awesome! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason componentWillReceiveProps is being called with identical props. We need to compare previous props with new props to make sure state is changing from closed to open before calling this.open(). Otherwise we're calling this.open() even when state isn't changing. Same with this.close().