-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for Preferences API #63
Open
JayPanoz
wants to merge
18
commits into
develop
Choose a base branch
from
PrefAPI-prep
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept the constrain as an argument, probably a good idea to have something in Reader to sync breakpoints for arrows though.
inside the container, as is the case for Bottom Sheet
So that when focus-visible, outline is entirely shown at the bottom, and element is not hidden below sticky header at the top
Deploying playground with
|
Latest commit: |
8080d9a
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b17bd8d6.playground-7xz.pages.dev |
Branch Preview URL: | https://prefapi-prep.playground-7xz.pages.dev |
So that it’s not focusable when it’s not populated but it becomes when it is.
As part of future-proofing #55
Otherwise will be true for less as well, which isn’t the intent here. #55
Check window exists in all hooks requiring a window/document
So that state logic is shared across custom hooks
No need in useEffects cos’ if mounted, then window, document, etc. exist
In addition:
|
- Make inert when collapsed so that you can’t tab buttons since the container is open and rendered in that case. - Improve Aria label of docking slot (say if closed or collapsed, and the action it contains). - Revert FocusScope change of Docked Sheet as it caused a trap (chevron button)
Finally, this PR updates dependencies and removes Vercel, that was originally added only to be pinned and get around a bug in Cloudflare's next-on-pages and make the project deployable. It also remove the |
Resolves #34
Following ReadiumCSS changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a transitional PR whose purpose is to set the Playground for the Preferences API in ts-toolkit.
At the time of drafting, it contains the following changes:
Reader
) so that it’s handled in a single place – will come in handy with the Preference for the Arrows’ Visibility;consistency of React Aria’sreverted as it created a focus trap;FocusScope
inDockedSheet
has been improved;DockPanel
component.These changes don’t introduce any change in how the Reader and its components currently work, or their affordances behave.
Considering the significant changes the Preferences API will bring to the Playground, the upgrade and migration should be handled as a second step, in another specific PR.