fix image payload sent to host #83
Merged
+107
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a test epub from https://kb.daisy.org/publishing/docs/html/images-desc.html |
|
This is a draft version, I'm thinking what can i do with existing image content description |
Is it better to load html content in thorium cache and get image element from cssSelector ? pros : we can get the figure/details element and N characters before and after without to rely from the navigator-js. Cons : the xhtml caching must be loaded before and it is a double memory consumption (from webview thread and window thread) but it's already used by the search feature
|
several major integration errors in this code (not your fault, I am refactoring some variable names to make things clearer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.