Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query logic in Swift #227

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Add query logic in Swift #227

merged 6 commits into from
Apr 11, 2024
+143 −49

Conversation

zunda-pixel
Copy link

🧰 Changes

  • Add query logic in Swift
    • URLQueryItem has url encode logic

🧬 QA & Testing

I fixed test code in /httpsnippet/src/targets/swift/urlsession/fixtures/

npm run test

@zunda-pixel zunda-pixel marked this pull request as ready for review April 11, 2024 14:40
@zunda-pixel
replace indent to opts.indent
Loading
Loading status checks…
0af02c0
erunion
erunion previously approved these changes Apr 11, 2024
View reviewed changes
@erunion erunion dismissed their stale review April 11, 2024 16:14

approved before running tests

@erunion erunion merged commit f30e998 into readmeio:main Apr 11, 2024
3 checks passed
@erunion
Copy link
Member

erunion commented Apr 11, 2024

Published to 10.0.2. Thanks!

@zunda-pixel zunda-pixel deleted the fix-url-query-swift branch April 11, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zunda-pixel @erunion