Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthicalAds: inject ad only if we detect a theme we know #328

Closed
humitos opened this issue May 29, 2024 · 0 comments · Fixed by #329
Closed

EthicalAds: inject ad only if we detect a theme we know #328

humitos opened this issue May 29, 2024 · 0 comments · Fixed by #329
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented May 29, 2024 •
edited
Loading

Yesterday we deploy the initial version for EA addons that enabled it in all the projects hosted on Read the Docs. However, we rolled it back because we found some inconsistencies and we didn't feel comfortable with it.

We ended up with the following plan:

I think the first step for next addons release is to "only inject the ad if we detect is a theme we know, avoid using stickybox" until we decide what to do here and how to solve it

Slack Discussion: https://readthedocs.slack.com/archives/C02J81RSF/p1716916646608969

Related
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap May 29, 2024
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels May 29, 2024
humitos added a commit that referenced this issue May 29, 2024
@humitos
EthicalAds: inject ad only if it's a known theme and above the fold
2b7e8fe 
Disable using `stickybox` style for now and only inject the ad if we are sure
it's a known theme and the ad it's going to be above the fold.

In a following iteration, we will want to use `stickybox` in the other cases but
we want to have the ability to disable the re-placement in smaller screens.

Closes #328
This was referenced May 29, 2024
Merged
Open
humitos added a commit that referenced this issue May 29, 2024
@humitos @ericholscher
EthicalAds: inject ad only if it's a known theme and above the fold (#…
750d6b0 
…329)

Disable using `stickybox` style for now and only inject the ad if we are
sure it's a known theme and the ad it's going to be above the fold.

In a following iteration, we will want to use `stickybox` in the other
cases but we want to have the ability to disable the re-placement in
smaller screens.

Closes #328

---------

Co-authored-by: Eric Holscher <[email protected]>
@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EthicalAds: inject ad only if it's a known theme and above the fold readthedocs/addons
1 participant
@humitos