EthicalAds: inject ad only if it's a known theme and above the fold #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable using `stickybox` style for now and only inject the ad if we are sure it's a known theme and the ad it's going to be above the fold. In a following iteration, we will want to use `stickybox` in the other cases but we want to have the ability to disable the re-placement in smaller screens. Closes #328
humitos
requested review from
agjohnson and
ericholscher
and removed request for
agjohnson
humitos
added a commit
that referenced
this pull request
May 29, 2024
This commit implements the following logic to place an ad in order: 1. If there is an explicit placement, we use that placement. 2. If the doctool/theme is known **and** we find a right placement (eg. sidebar), **and** the ad is gonna be above the fold, we put the ad there since we know it's a good fit for it. 3. Otherwise, if the screen width is >1300px we add a floating `stickybox` ad. Besides, we add an event handler that will _hide the ad_ if the user resizes the window and it ends up being <1300px. On top of #329
|
#330 looks good on top of this 👍 |
ericholscher
approved these changes
May 29, 2024
This commit implements the following logic to place an ad in order: 1. If there is an explicit placement, we use that placement. 2. If the doctool/theme is known **and** we find a right placement (eg. sidebar), **and** the ad is gonna be above the fold, we put the ad there since we know it's a good fit for it. 3. Otherwise, if the screen width is >1300px we add a floating `stickybox` ad. Besides, we add an event handler that will _hide the ad_ if the user resizes the window and it ends up being <1300px. On top of #329 --------- Co-authored-by: Eric Holscher <[email protected]>
…ical-no-stickybox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable using
stickyboxstyle for now and only inject the ad if we are sure it's a known theme and the ad it's going to be above the fold.In a following iteration, we will want to use
stickyboxin the other cases but we want to have the ability to disable the re-placement in smaller screens.Closes #328