Try CSS variable again #545
+72
−56
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Also for illustration only |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /* Theme defaults? */ | ||
| :root { | ||
| --readthedocs-font-size: 10px; | ||
| --readthedocs-flyout-font-size: 30px; | ||
| } |
|
There was a problem hiding this comment. And also not needed There was a problem hiding this comment. We can probably create another HTML file to keep in the repository and show this as example 👍🏼 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import styleSheetFlyout from "./flyout.css"; | ||
|
|
||
| import { CSSResult } from "lit"; | ||
|
|
||
| // We use a native construct here as Lit's CSSResult is largely read only. | ||
| export const defaultStyleSheet = new CSSStyleSheet(); | ||
|
|
||
| /* | ||
| * Specific styles based on documentation tools and themes | ||
| * | ||
| * Usage of `@layer` at-rule pushes this rules down a step in | ||
| * precedence/priority. This allows a user `:root` rule to override these | ||
| * values. | ||
| **/ | ||
| defaultStyleSheet.replaceSync(` | ||
|
There was a problem hiding this comment. I don't like too much that we are writing all these CSS in a JS file. Can't we just have a There was a problem hiding this comment. Actually, I don't really understand why you migrated from |
||
| @layer defaults { | ||
| :root[data-readthedocs-tool="mkdocs-material"] { | ||
| --readthedocs-font-size: 0.58rem; | ||
| --readthedocs-flyout-font-size: 0.58rem; | ||
| } | ||
|
|
||
| :root[data-readthedocs-tool="antora"] { | ||
| --readthedocs-font-size: 0.7rem; | ||
| --readthedocs-flyout-font-size: 0.7rem; | ||
| } | ||
|
|
||
| :root[data-readthedocs-tool="mdbook"] { | ||
| --readthedocs-font-size: 1.3rem; | ||
| --readthedocs-flyout-font-size: 1.3rem; | ||
| } | ||
|
|
||
| :root[data-readthedocs-tool="sphinx"][data-readthedocs-tool-theme="furo"] { | ||
| --readthedocs-font-size: 0.75rem; | ||
| --readthedocs-flyout-font-size: 0.75rem; | ||
| } | ||
|
|
||
| :root[data-readthedocs-tool="sphinx"][data-readthedocs-tool-theme="immaterial"] { | ||
| --readthedocs-font-size: 0.58rem; | ||
| --readthedocs-flyout-font-size: 0.58rem; | ||
| } | ||
| } | ||
| `); | ||
|
|
||
| const styleSheets = [styleSheetFlyout]; | ||
|
|
||
| for (let styleSheet of styleSheets) { | ||
| if (styleSheet instanceof CSSResult) { | ||
| styleSheet = styleSheet.styleSheet; | ||
| } | ||
| for (const rule of styleSheet.cssRules) { | ||
| if (rule instanceof CSSLayerBlockRule && rule.name == "defaults") { | ||
| defaultStyleSheet.insertRule(rule.cssText); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for illustration only.