Projects: enable pull request builds by default - #13249
Draft
ericholscher wants to merge 4 commits into
Draft
Conversation
New projects now have `external_builds_enabled` set to True, and the docs describe pull request previews as on by default. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvLJgam4eFipmYnijL4bZY
Keying the dashboard announcement off `external_builds_enabled` hides it for everyone now that the setting defaults to True. Key it off having an external version instead, so the nudge stays until a real pull request build happens. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvLJgam4eFipmYnijL4bZY
Matches the neighboring announcement branches, and avoids a subquery. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvLJgam4eFipmYnijL4bZY
Semantic linefeeds and a comma splice, plus match the repo's fixture idiom in the announcement test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvLJgam4eFipmYnijL4bZY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request previews are opt-in today, so anyone who onboards without finding the setting silently misses one of the best parts of the platform. This makes
external_builds_enableddefault toTrue. Follow-up to #13039, which was closed in favor of a fresh branch — same model change, plus the docs it was missing.The dashboard announcement is the part worth a careful read. It was keyed off
external_builds_enabled, so under the new default it would never appear again. But the point of the nudge is that someone hasn't seen a preview, not that they haven't ticked a box, so it now keys off having an external version (projects/views/private.py). The matching copy change is readthedocs/ext-theme#772 — land them together, or the call to action stops matching when it appears.Risks and open questions: