Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support glossary / term and sphinxcontrib-bibtex #149

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 27, 2021

Based on #146
Closes #96

@humitos humitos requested a review from a team September 27, 2021 11:25
@humitos humitos force-pushed the humitos/glossary-citation branch 4 times, most recently from 95db41a to b3a3e65 Compare September 27, 2021 11:46
@humitos humitos force-pushed the humitos/glossary-citation branch from b3a3e65 to a70f2b6 Compare September 27, 2021 12:11
@humitos humitos force-pushed the humitos/glossary-citation branch from a70f2b6 to 6b41932 Compare September 27, 2021 14:34
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough.


See the :term:`sphinx:environment` definition in the glossary.

To enable ``hoverxref`` on glossary terms, you need to add ``'term'`` to :confval:`hoverxref_roles`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enabled by default? I feel like it should be..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not enable tooltips by default. The extension itself has a :hoverxref: role where you can manually specify which references you want to show tooltips on.

Besides, it has a simplified way to enable tooltips on all references by using hoverxref_auto_ref = True in your config file or selectively by role using hoverxref_roles.

-------------------------------------

If you want to show a tooltip on `sphinxcontrib-bibtex <https://sphinxcontrib-bibtex.readthedocs.io/en/latest/>`_ cites,
you just need to enable it in :confval:`hoverxref_domains` by adding ``'cite'`` to that list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should standardize where we put this info. It's at the bottom of the previous section, and top here. Probably a subhead like Enable this feature or similar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a Enable this feature section may be too big for each of them since the content itself is really small. However, standardizing where to describe how to enable them makes sense to me.

Base automatically changed from humitos/embed-api-v3 to master September 28, 2021 10:48
@humitos humitos merged commit 080ce33 into master Sep 28, 2021
@humitos humitos deleted the humitos/glossary-citation branch September 28, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sphinxcontrib-bibtex
2 participants